1492374 - [remote-dbg-next] Remove ADB Helper from user profiles after migrating to Fx 64

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, enhancement, P1)

Description

[Julian Descottes [:jdescottes]]

Follow up to Bug 1491315

Starting with Firefox 64, ADB Helper will move to legacy/disabled (see https://bugzilla.mozilla.org/show_bug.cgi?id=1491315#c14) 

Our replacement for ADB Helper is a new extension with a new ID, so we should remove the old extension somehow.

We could serve a new version of ADB Helper that removes itself, however we still might want to do releases of ADB Helper to address blocking bugs until Fx ESR > 64.0. So if we can :
- release ADB Helper v0.13, Fx 64+ only, uninstalls itself
- keep updating ADB Helper v0.12.x for Fx63 or earlier 

Then this is an option. If not, we should have some code in our adb module to uninstall the old extension.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

I wonder we can simply remove the old addon when we install the new extension in WebIDE?

Comment 2

[Julian Descottes [:jdescottes]]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #1)
> I wonder we can simply remove the old addon when we install the new
> extension in WebIDE?

That's probably the easiest option, yes.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1492374 - Move all ADB related preferences out of webide;r=ladybenko

While this is not strictly related for uninstalling ADB helper this
small cleanup avoids duplicating the declaration of the adb extension
in two different preferences.

The URL preference also moves to a devtools-shared preference as there
is not much sense to keep it webide only.

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1492374 - Remove unused webide Addon abstract class;r=ladybenko

The addons module will be further simplified and transformed into a shared module
in coming bgs. Here since we introduce more ADBAddon-specific logic and we have no other
implementation for the Addon class, I prefer to remove it. (note that it was already doing 
some adb-only processing in the current version anyway)

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1492374 - Uninstall ADB Helper when starting WebIDE addons module;r=ladybenko

Depends on D7058. To test this you should first install ADB helper
(xpis at https://ftp.mozilla.org/pub/labs/fxos-simulator/adb-helper/mac64/)
and then start webIDE. Normally ADB Helper should be removed.

Comment 6

[Belén [:ladybenko]]

Comment on attachment 9012530 [details]
Bug 1492374 - Move all ADB related preferences out of webide;r=ladybenko

Belén [:ladybenko] has approved the revision.

Comment 7

[Belén [:ladybenko]]

Comment on attachment 9012531 [details]
Bug 1492374 - Remove unused webide Addon abstract class;r=ladybenko

Belén [:ladybenko] has approved the revision.

Comment 8

[Belén [:ladybenko]]

Comment on attachment 9012532 [details]
Bug 1492374 - Uninstall ADB Helper when starting WebIDE addons module;r=ladybenko

Belén [:ladybenko] has approved the revision.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df4088486e03
Move all ADB related preferences out of webide;r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/e68feba6bf01
Remove unused webide Addon abstract class;r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/770892829289
Uninstall ADB Helper when starting WebIDE addons module;r=ladybenko

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/df4088486e03
https://hg.mozilla.org/mozilla-central/rev/e68feba6bf01
https://hg.mozilla.org/mozilla-central/rev/770892829289