1492436 - Delete a recurring item if deleting the last occurrence

Status: RESOLVED FIXED

(Calendar :: Dialogs, enhancement)

Description

[[:MakeMyDay]]

When deleting occurences of recurring events, the user currently can end up to have all occurences deleted, but the parent item stays in the calendar (however not accessible to the user anymore).

We should delete the recurring event if we delete the last occurrence of a recurring event.

As a folow up, we should over a cleanup job to remove recurring events without occurrences from the users calandars.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

This seems easy to do if the rule is finite, especially so if it has a COUNT component since we can just compare the number of exdates. For those with UNTIL however, we'd have to iterate all the occurrences until rule end while removing from a Set with the exdates. For a very long running rule I think this could have a performance impact.

The same goes for the cleanup job, I think this could impact performance as well. We also need to figure out how to message this, because if it is a meeting event then deleting it may cause emails to be sent out.

Don't get me wrong though, I think it would be great to do this!

Comment 2

[[:MakeMyDay]]

Attachment: DeleteRecurringItemWhenDeletingTheLastOccurrence-V1.diff

For the cleanup, I will file a separate bug.

Comment 3

[[:MakeMyDay]]

Of cause this is just for finite rule or an rdate collection, since for infinte rules, you never get to have a last occurrence.

Performace might be an issue for the cleanup, that should be a background operation once all calendars have been loaded and TB is more or less ideling.

Comment 4

[Stefan Sitter [:ssitter]]

See my previous report for this: bug 351850.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 9010218 [details] [diff] [review]
DeleteRecurringItemWhenDeletingTheLastOccurrence-V1.diff

Review of attachment 9010218 [details] [diff] [review]:
-----------------------------------------------------------------

Ok, lets take this. I'm a bit cautious still because I don't want to regress performance, so maybe we can run this on beta a bit to get a feel for it, and then reconsider for ESR.

Comment 6

[[:MakeMyDay]]

Sure, there's no need to rush. So let's let it bake a while on beta.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/aa9c13717f77
Delete a recurring item if the last occurrence is deleted; r=philipp

Comment 8

[Jorg K (CEST = GMT+2)]

TB 65 beta 2 / Cal 6.7:
https://hg.mozilla.org/releases/comm-beta/rev/6cb2a1aba7f156a166a342826b8c6876b77802ef