1492536 - The yellow "Disabled" content blocking note on Firefox Control Centre is too big in Slovenian language

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Lan Glad [:upwinxp]]

Attachment: The yellow "Onemogočeno" notice is too big

The Control Centre panel (Firefox 63.0 Beta 7, Windows 10) contains a "Tracking Protection" section where blocking can be disabled or enabled for a site. When blocking is temporarily disabled, a yellow rectangle with a warning sign and word "Disabled" is shown.

In the Slovenian (SL) localisation of Firefox, the word "Disabled" is translated as "Onemogočeno". The word is too long for the interface, thus breaking the "Tracking Protection" heading into two lines and making and the rectangle too high.

The doorhanger should be redesigned to prevent elements from wrapping unexpectedly after being translated with longer words.

Comment 1

[Johann Hofmann [:johannh]]

This was fixed in Nightly with bug 1489581 which I'm planning to uplift to Beta now.

Comment 2

[Johann Hofmann [:johannh]]

Fixed by bug 1489581, can you please verify?

Thanks!

Comment 3

[Lan Glad [:upwinxp]]

Attachment: The "Onemogočeno" notice after fixing (Nightly 64, 2018-09-20)

The yellow notice looks good now, thanks!

I however see in Bug 1489581 attachments that there used to be three "Add Blocking..." links in the Content Blocking section. These are now not displayed for me. Is that alright?

See the newly attached image (Nightly 64, 2018-09-20).

Comment 4

[Johann Hofmann [:johannh]]

Yeah, that seems alright. You probably have enabled all three (hence no "Add Blocking..."), but they are also not active because you added an exception, so we just show no label at all.

Thanks!