1492576 - If no protection is enabled, don't offer the user the ability to disable protection or report a problem

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Tanvi Vyas[:tanvi]]

* User has FastBlock, Tracking Protection, and Third Party Cookies turned off in normal browsing mode.
* Go to cnn.com (or any page with trackers)
* Click the Control Center.

User is offered the "Disable Blocking for this site" and the "Report a problem" buttons.  But Firefox has not blocked anything.  The disable button will do nothing to fix the current page load.  The report will be bogus and unrelated to Content Blocking.

Hide these buttons in this case.

This needs to be uplifted to 63, or it will be the default case for most users.

Comment 1

[Johann Hofmann [:johannh] - On leave until October, slow/no response on BMO, DM me if urgent]

Attachment: Bug 1492576 - If no protection is enabled, don't offer the user the ability to disable protection or report a problem. r=Ehsan

Comment 2

[:ehsan akhgari]

Comment on attachment 9010676 [details]
Bug 1492576 - If no protection is enabled, don't offer the user the ability to disable protection or report a problem. r=Ehsan

:Ehsan Akhgari has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f139e12a965a
If no protection is enabled, don't offer the user the ability to disable protection or report a problem. r=Ehsan

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f139e12a965a

Comment 5

[Johann Hofmann [:johannh] - On leave until October, slow/no response on BMO, DM me if urgent]

Comment on attachment 9010676 [details]
Bug 1492576 - If no protection is enabled, don't offer the user the ability to disable protection or report a problem. r=Ehsan

Approval Request Comment
[Feature/Bug causing the regression]: Not really a regression, more an oversight
[User impact if declined]: Users can add content blocking exceptions and report breakage when no content was blocked, which isn't desired by UX
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: Turn off all content blocking categories in about:preferences (but not content blocking itself). Go to a site with trackers. Open the control center. You should not see the "Disable Protection" button or the "Report Breakage" link.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Updating a few lines of CSS to hide these items.
[String changes made/needed]: None

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9010676 [details]
Bug 1492576 - If no protection is enabled, don't offer the user the ability to disable protection or report a problem. r=Ehsan

Minimal css patch ficing a P1 bug, uplift approved for 63 beta 9, thanks.

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b829bb18e57a

Comment 8

[Catalin Sasca, QA [:csasca]]

I successfully reproduced the issue using Firefox Nightly 64.0a1 (2018-09-19) under Windows 10 (x64) using STR from Comment 0.

The issue is no longer reproducible on Firefox Beta 63.0b9 and latest Nightly 64.0a1 (2018-09-25). Tests were performed under Windows 10 (x64), Ubuntu 16.04 (x64) and macOS 10.13.