1492652 - Avoid cloning of log level when initialising logging

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement, P1)

Description

[Andreas Tolfsen ❲:ato❳]

In geckodriver we clone the log level when calling logging::init_with_level,
but since it implements the Copy trait we can get away with simply
dereferencing it.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: geckodriver: avoid cloning log level on init

Instead of cloning we can dereference the logging level since it
derives the Copy trait.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 9010489 [details] [diff] [review]
geckodriver: avoid cloning log level on init

Review of attachment 9010489 [details] [diff] [review]:
-----------------------------------------------------------------

I would like to forward this to James, given that I miss the connection between Copy and Clone here, and which side-effects this could have.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9d053ee3931
geckodriver: avoid cloning log level on init; r=jgraham

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 9010489 [details] [diff] [review]
geckodriver: avoid cloning log level on init

Review of attachment 9010489 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/geckodriver/src/main.rs
@@ +179,5 @@
>              _ => Some(logging::Level::Trace),
>          }
>      };
>      if let Some(ref level) = log_level {
> +        logging::init_with_level(*level).unwrap();

Could have been

if let Some(level) = log_level {
    logging::init_with_level(level).unwrap();
}

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f9d053ee3931