1492686 - [wpt-sync] Sync PR 13090 - Set default channel count for AnalyserNode to 2

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 13090 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13090
Details from upstream follow.

 wrote:
>  Set default channel count for AnalyserNode to 2
>  
>  
>  This was deliberately changed
>  (https://github.com/WebAudio/web-audio-api/pull/1397 ) but the tests
>  have not been updated
>  
>  Upstreamed from https://github.com/servo/servo/pull/21712 [ci skip]

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4072dc25858a2a27cdfdf4cbf17de4871ee4c89

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Result changes from PR not available.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f02da37bce59
[wpt PR 13090] - Set default channel count for AnalyserNode to 2, a=testonly

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/66d3ccc4fef2
Backed out changeset f02da37bce59 for failing ctor-analyser.html and test-analysernode.html CLOSED TREE

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset f02da37bce59 for failing ctor-analyser.html and test-analysernode.html

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=3c99e9f9a6182a85cecf541be63188a435262ec6

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/66d3ccc4fef2649d5878679dcca4f6fe56e3888f

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=201264195&repo=mozilla-inbound&lineNumber=5608

[task 2018-09-24T20:23:39.561Z] 20:23:39     INFO - TEST-START | /webaudio/the-audio-api/the-analysernode-interface/ctor-analyser.html
[task 2018-09-24T20:23:39.582Z] 20:23:39     INFO - Setting pref privacy.reduceTimerPrecision (false)
[task 2018-09-24T20:23:39.814Z] 20:23:39     INFO - 
[task 2018-09-24T20:23:39.814Z] 20:23:39     INFO - TEST-PASS | /webaudio/the-audio-api/the-analysernode-interface/ctor-analyser.html | > [invalid constructor]  
[task 2018-09-24T20:23:39.815Z] 20:23:39     INFO - TEST-PASS | /webaudio/the-audio-api/the-analysernode-interface/ctor-analyser.html |   new AnalyserNode() threw TypeError: "Not enough arguments to AnalyserNode.". 
[task 2018-09-24T20:23:39.816Z] 20:23:39     INFO - TEST-PASS | /webaudio/the-audio-api/the-analysernode-interface/ctor-analyser.html |   new AnalyserNode(1) threw TypeError: "Argument 1 of AnalyserNode.constructor is not an object.". 
[task 2018-09-24T20:23:39.816Z] 20:23:39     INFO - TEST-PASS | /webaudio/the-audio-api/the-analysernode-interface/ctor-analyser.html |   new AnalyserNode(context, 42) threw TypeError: "Value can't be converted to a dictionary.". 
[task 2018-09-24T20:23:39.816Z] 20:23:39     INFO - TEST-PASS | /webaudio/the-audio-api/the-analysernode-interface/ctor-analyser.html | < [invalid constructor] All assertions passed. (total 3 assertions) 
[task 2018-09-24T20:23:39.817Z] 20:23:39     INFO - TEST-PASS | /webaudio/the-audio-api/the-analysernode-interface/ctor-analyser.html | > [default constructor]  
[task 2018-09-24T20:23:39.817Z] 20:23:39     INFO - TEST-PASS | /webaudio/the-audio-api/the-analysernode-interface/ctor-analyser.html |   node0 = new AnalyserNode(context) did not throw an exception. 
[task 2018-09-24T20:23:39.818Z] 20:23:39     INFO - TEST-PASS | /webaudio/the-audio-api/the-analysernode-interface/ctor-analyser.html |   node0 instanceof AnalyserNode is equal to true. 
[task 2018-09-24T20:23:39.818Z] 20:23:39     INFO - TEST-PASS | /webaudio/the-audio-api/the-analysernode-interface/ctor-analyser.html |   node0.numberOfInputs is equal to 1. 
[task 2018-09-24T20:23:39.819Z] 20:23:39     INFO - TEST-PASS | /webaudio/the-audio-api/the-analysernode-interface/ctor-analyser.html |   node0.numberOfOutputs is equal to 1. 
[task 2018-09-24T20:23:39.819Z] 20:23:39     INFO - TEST-UNEXPECTED-FAIL | /webaudio/the-audio-api/the-analysernode-interface/ctor-analyser.html | X node0.channelCount is not equal to 2. Got 1. - assert_true: expected true got false
[task 2018-09-24T20:23:39.820Z] 20:23:39     INFO - _logFailed/<@http://web-platform.test:8000/webaudio/resources/audit.js:50:7



[task 2018-09-24T20:23:46.173Z] 20:23:46     INFO - TEST-START | /webaudio/the-audio-api/the-analysernode-interface/test-analysernode.html
[task 2018-09-24T20:23:46.189Z] 20:23:46     INFO - PID 22254 | JavaScript error: , line 0: InvalidStateError: An attempt was made to use an object that is not, or is no longer, usable
[task 2018-09-24T20:23:46.288Z] 20:23:46     INFO - 
[task 2018-09-24T20:23:46.289Z] 20:23:46     INFO - TEST-UNEXPECTED-FAIL | /webaudio/the-audio-api/the-analysernode-interface/test-analysernode.html | Test AnalyserNode API - assert_equals: analyser node has 2 input channels by default expected 2 but got 1
[task 2018-09-24T20:23:46.290Z] 20:23:46     INFO - testNode@http://web-platform.test:8000/webaudio/the-audio-api/the-analysernode-interface/test-analysernode.html:28:7
[task 2018-09-24T20:23:46.290Z] 20:23:46     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1573:20
[task 2018-09-24T20:23:46.291Z] 20:23:46     INFO - test@http://web-platform.test:8000/resources/testharness.js:544:21
[task 2018-09-24T20:23:46.292Z] 20:23:46     INFO - @http://web-platform.test:8000/webaudio/the-audio-api/the-analysernode-interface/test-analysernode.html:232:5
[task 2018-09-24T20:23:46.293Z] 20:23:46     INFO - 
[task 2018-09-24T20:23:46.293Z] 20:23:46     INFO - TEST-UNEXPECTED-FAIL | /webaudio/the-audio-api/the-analysernode-interface/test-analysernode.html | Test AnalyserNode's ctor API - assert_equals: analyser node has 2 input channels by default expected 2 but got 1
[task 2018-09-24T20:23:46.293Z] 20:23:46     INFO - testConstructor@http://web-platform.test:8000/webaudio/the-audio-api/the-analysernode-interface/test-analysernode.html:132:7
[task 2018-09-24T20:23:46.294Z] 20:23:46     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1573:20
[task 2018-09-24T20:23:46.295Z] 20:23:46     INFO - test@http://web-platform.test:8000/resources/testharness.js:544:21


Jgraham, could you, please, take a look?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/67d533e232f2
[wpt PR 13090] - Set default channel count for AnalyserNode to 2, a=testonly

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/67d533e232f2