1492736 - [remote-dbg-next] Prevent locking device when connected to remote debugging

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

Feature requested for web compat support.

When a Device is being remote debugged, it should not lock. This feature is currently available in Chrome's remote debug solution.

Comment 1

[Brian Birtles (:birtles)]

I believe Makoto is looking into this.

Comment 2

[Makoto Kato [:m_kato]]

Past years, we have implemented WeakLock API for B2G (and also Android backend).  We may be able to use that API for this.

Comment 3

[Makoto Kato [:m_kato]]

Ah, bug 1369194 removed WebIDL...

Comment 4

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4301a1bdf20280fc2fd514b25eb0d91c0f07745a

Comment 5

[Makoto Kato [:m_kato]]

Attachment: Bug 1492736 - Part 1. Add nsIWakeLock to manage wake lock from devtools.

DevTools wants to use wake lock to keep screen.  But since MozWakeLock is
removed by bug 1369194, there is no way to unlock wake lock from script.

So this issue adds nsIWakeLock to unlock wake lock.

Comment 6

[Makoto Kato [:m_kato]]

Attachment: Bug 1492736 - Part 2. Acquire wake lock when tab is attached.

Use wake lock to keep screen when tab is attached from debugger.

Depends on D7158

Comment 7

[Makoto Kato [:m_kato]]

Julian, I have a question for this.

Chrome/Android seems to keep wake lock when devtool in desktop selects same tab in remote device.  Example, when remote device has A and B tab, and foreground in remote device is A tab, devtool only keeps wake lock when devtool selects foreground's A tab.  If devtool selects B tab (B isn't foreground in remote device), wake lock is unlocked.

Does Firefox's devtools use same behaviour?

Or, when device is connected (via wifi or USB) to devtool, should wake lock be kept even if selected tab in devtool isn't foreground in remote device?

Comment 8

[:Harald Kirschner :digitarald]

> Or, when device is connected (via wifi or USB) to devtool, should wake lock be kept even if selected tab in devtool isn't foreground in remote device?

Chrome's behavior seems more like a side effect. Is there value for users that I am missing that tab-centric wake-lock adds?

Comment 9

[Makoto Kato [:m_kato]]

(In reply to :Harald Kirschner :digitarald from comment #8)
> > Or, when device is connected (via wifi or USB) to devtool, should wake lock be kept even if selected tab in devtool isn't foreground in remote device?
> 
> Chrome's behavior seems more like a side effect. Is there value for users
> that I am missing that tab-centric wake-lock adds?

I don't know. I think that Chrome approach is that they connect to device automatically (remote device tab of Chrome shows "connected" state when adb connection is found), so they acquire wake lock when selecting tab. Our devtool connects to device manually, so I think that it is better to acquire wake lock when connected to device.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/77ccb4525731
Part 1. Add nsIWakeLock to manage wake lock from devtools. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/e358e36fc048
Part 2. Acquire wake lock when device actor is attached. r=ochameau

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6868407681bb
Fix eslint failure, missing comma. r=me

Comment 12

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/77ccb4525731
https://hg.mozilla.org/mozilla-central/rev/e358e36fc048
https://hg.mozilla.org/mozilla-central/rev/6868407681bb