Closed Bug 1492745 Opened 6 years ago Closed 6 years ago

Remove PWebRenderBridge::Create()

Categories

(Core :: Graphics: WebRender, enhancement)

Product:
Core
Component:
Graphics: WebRender
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file, 1 obsolete file)

patch - Remove PWebRenderBridge::Create()
5.32 KB, patch
sotaro
: review+
Details | Diff | Splinter Review 
PWebRenderBridge::Create() is sync ipc and it does nothing effective now. The function should be removed.
Blocks: 1492397
Attachment #9010545 - Flags: review?(matt.woodrow)
Attachment #9010545 - Flags: review?(matt.woodrow) → review+
Comment on attachment 9010545 [details] [diff] [review]
patch - Remove PWebRenderBridge::Create()

:froydnj, can you review a change to sync-messages.ini? It just removes unnecessary sync ipc.
Attachment #9010545 - Flags: review?(nfroyd)
Comment on attachment 9010545 [details] [diff] [review]
patch - Remove PWebRenderBridge::Create()

Review of attachment 9010545 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on the sync-messages.ini change.
Attachment #9010545 - Flags: review?(nfroyd) → review+
Rebased.
Attachment #9010545 - Attachment is obsolete: true
Attachment #9011998 - Flags: review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd8defc97c55
Remove PWebRenderBridge::Create() r=mattwoodrow,froydnj
https://hg.mozilla.org/mozilla-central/rev/fd8defc97c55
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: