1492759 - Stop using JS_GetCompartmentPrincipals for Xray expandos

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement, P2)

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1492759 - Use the caller's principal instead of the wrapper's principal for Xray expandos. r?bholley

Another option is to use the origin stored in CompartmentPrivate/CompartmentOriginInfo.
I implemented that first, but I want to encapsulate the principal in CompartmentOriginInfo
as much as possible without adding a getter for it (we would need one here). Furthermore,
I think the current patch will do the right thing with compartment-per-site if we ever
decide to move to that.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1492759 - Use the principal stored in CompartmentOriginInfo instead of JS_GetCompartmentPrincipals for Xray expandos. r?bholley

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 9010859 [details]
Bug 1492759 - Use the principal stored in CompartmentOriginInfo instead of JS_GetCompartmentPrincipals for Xray expandos. r?bholley

Bobby Holley (:bholley) has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa86cfaf0db8
Use the principal stored in CompartmentOriginInfo instead of JS_GetCompartmentPrincipals for Xray expandos. r=bholley

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/fa86cfaf0db8