Closed Bug 1492759 Opened Last year Closed Last year

Stop using JS_GetCompartmentPrincipals for Xray expandos

Categories

(Core :: XPConnect, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Another option is to use the origin stored in CompartmentPrivate/CompartmentOriginInfo.
I implemented that first, but I want to encapsulate the principal in CompartmentOriginInfo
as much as possible without adding a getter for it (we would need one here). Furthermore,
I think the current patch will do the right thing with compartment-per-site if we ever
decide to move to that.
Priority: -- → P2
Attachment #9010556 - Attachment is obsolete: true
Comment on attachment 9010859 [details]
Bug 1492759 - Use the principal stored in CompartmentOriginInfo instead of JS_GetCompartmentPrincipals for Xray expandos. r?bholley

Bobby Holley (:bholley) has approved the revision.
Attachment #9010859 - Flags: review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fa86cfaf0db8
Use the principal stored in CompartmentOriginInfo instead of JS_GetCompartmentPrincipals for Xray expandos. r=bholley
https://hg.mozilla.org/mozilla-central/rev/fa86cfaf0db8
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.