Closed Bug 149283 Opened 22 years ago Closed 22 years ago

Typo in xulsecurity.mn

Categories

(Core Graveyard :: Embedding: Mac, defect)

Product:
Core Graveyard
Component:
Embedding: Mac
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0.1

People

(Reporter: mikepinkerton, Assigned: mikepinkerton)

Details

(Keywords: topembed, Whiteboard: [needs a= drivers emailed 6/6])

Attachments

(1 file, 1 obsolete file)

again, the correct fix
540 bytes, patch
tao
: review+
alecf
: superreview+
jud
: approval+
Details | Diff | Splinter Review 
as tao pointed out in email, there's a typo in the xul security manifest file:

 7 locale/XXXX/pipnss, XXXX/locale/XXXX/pippki

which should read

 7 locale/XXXX/pippki, XXXX/locale/XXXX/pippki

patch upcoming
Attached patch fix typo (obsolete) — — Splinter Review 
can i get r/sr here?
Status: NEW → ASSIGNED
Keywords: topembed
Target Milestone: --- → mozilla1.0.1
Comment on attachment 86399 [details] [diff] [review]
fix typo

r=ccarlen
Attachment #86399 - Flags: review+
Comment on attachment 86399 [details] [diff] [review]
fix typo

>Index: mozilla/embedding/config/xulsecurity.mn
>===================================================================
>RCS file: /cvsroot/mozilla/embedding/config/xulsecurity.mn,v
>retrieving revision 1.1.2.1
>diff -u -2 -r1.1.2.1 xulsecurity.mn
>--- mozilla/embedding/config/xulsecurity.mn	17 Apr 2002 14:11:14 -0000	1.1.2.1
>+++ mozilla/embedding/config/xulsecurity.mn	5 Jun 2002 13:57:00 -0000
>@@ -5,5 +5,5 @@
> 
> content/pipnss, pipnss/content/pipnss
>-locale/XXXX/pipnss, XXXX/locale/XXXX/pippki

>+locale/XXXX/pippki, XXXX/locale/XXXX/pippki
Should this be "pipnss" like below instead?

+locale/XXXX/pipnss, XXXX/locale/XXXX/pipnss
> 
>
Comment on attachment 86399 [details] [diff] [review]
fix typo

tao, you're right, i'm an idiot.
Attachment #86399 - Attachment is obsolete: true
Comment on attachment 86412 [details] [diff] [review]
again, the correct fix

r=tao
Attachment #86412 - Flags: review+
Comment on attachment 86412 [details] [diff] [review]
again, the correct fix

sr=alecf
Attachment #86412 - Flags: superreview+
Keywords: adt1.0.1, mozilla1.0.1
Whiteboard: [needs a= drivers emailed 6/6]
please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword, and add the "fixed1.0.1" keyword.
Keywords: mozilla1.0.1 → mozilla1.0.1+
Attachment #86412 - Flags: approval+
adding adt1.0.1+ for checkin to 1.0.1
Keywords: adt1.0.1 → adt1.0.1+
please check this into the branch as soon as possible.
landed on trunk and branch
Keywords: adt1.0.1+ → fixed1.0.1
really fixed
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Keywords: mozilla1.0.1+
BRANCH:
http://lxr.mozilla.org/mozilla1.0/source/embedding/config/xulsecurity.mn#7

6 content/pipnss, pipnss/content/pipnss
7 locale/XXXX/pipnss, XXXX/locale/XXXX/pipnss

TRUNK:
http://lxr.mozilla.org/seamonkey/source/embedding/config/xulsecurity.mn#7

6 content/pipnss, pipnss/content/pipnss
7 locale/XXXX/pipnss, XXXX/locale/XXXX/pipnss

Verified FIXED using LXR.
Status: RESOLVED → VERIFIED
Keywords: fixed1.0.1 → verified1.0.1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: