Talos suites failing with "Non-local network connections are disabled and a connection attempt to www.mozilla.org (104.16.41.2) was made."

RESOLVED FIXED in Firefox 64

Status

defect
RESOLVED FIXED
9 months ago
8 months ago

People

(Reporter: aklotz, Assigned: aswan)

Tracking

Trunk
mozilla64
Unspecified
Windows
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

Reporter

Comment 1

9 months ago
I don't know what was causing this, but it is gone now.
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → WORKSFORME
Assignee

Comment 2

9 months ago
Its definitely not gone, its happening all over the place on inbound right now.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Reporter

Comment 3

9 months ago
And yet autoland was fine... wtf
Assignee

Comment 4

9 months ago
Since this only affects damp, perhaps its something coming from devtools?
Julian, any ideas?
Flags: needinfo?(jdescottes)
Reporter

Comment 5

9 months ago
Moving to General right now since this is clearly not isolated to Talos.
Component: Talos → General
Assignee

Comment 6

9 months ago
I have no idea why :aklotz was seeing this earlier but the latest recurrence is due to changes to pageloader in bug 1493867.  There's now a race where we might try to load one of the firstrun pages.  Sorry about the false alaram re devtools.
I'll have a patch ready momentarily.
Flags: needinfo?(jdescottes)
Assignee

Comment 7

9 months ago
I just pushed this to stop the orange:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6da5272fc16

But I think we should probably override this preference for all talos tests.  I couldn't figure out what the right place to do this is though.  Joel?
Flags: needinfo?(jmaher)
Comment hidden (Intermittent Failures Robot)
thanks for pushing a fix :aswan.  Is this needed for our unittests?  why is this only needed for the 'damp' test?  I don't have objections to running this on all perf tests which would mean adding this to:
https://searchfox.org/mozilla-central/source/testing/profiles/perf/user.js
Flags: needinfo?(jmaher)
Comment hidden (Intermittent Failures Robot)
Assignee

Comment 11

9 months ago
(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #9)
> thanks for pushing a fix :aswan.  Is this needed for our unittests?

I guess not from the fact that its not failing in other tests.  The specific problem here is that in bug 1493867 I changed pageloader so that it waits for the default window to appear and later dismisses it.  Any other test framework that disables non-local network connections and also displays the default window needs to deal with this somehow, but nothing changed recently so other harnesses either aren't affected or work around this some other way.

> why is
> this only needed for the 'damp' test?

That's a fine question, and I have no idea :/

> I don't have objections to running
> this on all perf tests which would mean adding this to:
> https://searchfox.org/mozilla-central/source/testing/profiles/perf/user.js

Okay, I thought I tried that locally and didn't see those prefs actually show up in the profile the harness created but I must have done something wrong.  I'll write the patch....
Assignee

Updated

9 months ago
No longer blocks: 1488554
Summary: Talos suites failing with "Non-local network connections are disabled and a connection attempt to www.mozilla.org (104.16.41.2) was made." when launcher process enabled by default → Talos suites failing with "Non-local network connections are disabled and a connection attempt to www.mozilla.org (104.16.41.2) was made."
Assignee

Updated

9 months ago
Assignee: nobody → aswan
(In reply to Andrew Swan [:aswan] from comment #11)
> (In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #9)
> > thanks for pushing a fix :aswan.  Is this needed for our unittests?
> 
> I guess not from the fact that its not failing in other tests.  The specific
> problem here is that in bug 1493867 I changed pageloader so that it waits
> for the default window to appear and later dismisses it.  Any other test
> framework that disables non-local network connections and also displays the
> default window needs to deal with this somehow, but nothing changed recently
> so other harnesses either aren't affected or work around this some other way.

Most other harnesses already set these prefs.
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)

Comment 17

8 months ago
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ae17adbfe8ca
Avoid loading remote firstrun pages during talos runs r=jmaher

Comment 18

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ae17adbfe8ca
Status: REOPENED → RESOLVED
Closed: 9 months ago8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.