Closed Bug 1492872 Opened Last year Closed Last year

Remove JSProto_Iterator

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

Details

Attachments

(1 file)

It is apparently completely unused.
I'm also willing to update the comment at the top of ProtoKey.h that talks about "binary XDR compatibility"... but I'm not sure what it should say. Neither `JSProto_` nor `ProtoKey` appears at all in XDR.cpp these days. Just delete it? Can we get rid of `imaginary` prototypes altogether?
Flags: needinfo?(jwalden+bmo)
Comment on attachment 9010666 [details]
Bug 1492872 - Remove JSProto_Iterator. r?jwalden

Jeff Walden [:Waldo] has approved the revision.
Attachment #9010666 - Flags: review+
XDR versioning is now on the embedding to rev build id all the time, so there's no XDR concern any more now as far as JSProtoKey goes.  (JSProtoKey *does* show up in bytecode in certain places, tho, I think, so if we still had the same bytecode version bumping as of old, it would be be troublesome to just change or remove at least some of these.)  We can change the comment.

Imaginary protos we've slowly been replacing with one-off slots in GlobalObject.  If we have indeed replaced all of them, we should remove imaginariness.
Flags: needinfo?(jwalden+bmo)
https://hg.mozilla.org/mozilla-central/rev/caccc6d0cd9a
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Assignee: nobody → jorendorff
You need to log in before you can comment on or make changes to this bug.