1492885 - browser_saveImageURL.js's throttle checks look broken

Status: NEW

(Toolkit :: Downloads API, defect, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

Bug 1360603 made it so that "Save As..." channels are marked as throttle-able.

Some regression tests were added for them as well.

Unfortunately, the checks look a bit busted:

See [1] and [2]. In both cases, we're using "ok()" when we probably want to be checking equality ("is()" or "Assert.equal"). As it stands, that first check is basically checking that true == true, and the second one just makes sure that channel.QueryInterface(Ci.nsIClassOfService).classFlags has any bit set to 1.

Unfortunately, switching these to is() or Assert.equal results in test failures, so I think this stuff is kinda broken. :/

I discovered this while removing some CPOWs in bug 1492482. I don't think I have the cycles right now to figure out what's going on with these test failures - but perhaps baku or mayhemer can take a look (as they reviewed the original patches).

In the meantime, I'm going to switch these checks to TODOs in bug 1492482.

[1]: https://searchfox.org/mozilla-central/rev/a0333927deabfe980094a14d0549b589f34cbe49/toolkit/content/tests/browser/browser_saveImageURL.js#43-48
[2]: https://searchfox.org/mozilla-central/rev/a0333927deabfe980094a14d0549b589f34cbe49/toolkit/content/tests/browser/browser_saveImageURL.js#79-84

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey baku, just putting this on your radar... should we be worried that this throttling stuff isn't actually working properly?