Closed Bug 1492912 Opened 2 years ago Closed 2 years ago

[MIPS] Make MacroAssemblerMIPSCompat::tagValue not assert if the payload is the same as output type register.

Categories

(Core :: JavaScript Engine: JIT, defect)

63 Branch
Other
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: dragan.mladjenovic, Assigned: dragan.mladjenovic)

Details

Attachments

(1 file)

No description provided.
Attached patch bug1492912.patchSplinter Review
Assignee: nobody → dragan.mladjenovic
Status: NEW → ASSIGNED
Attachment #9010708 - Flags: review?(jitbugs)
Comment on attachment 9010708 [details] [diff] [review]
bug1492912.patch

Review of attachment 9010708 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips32/MacroAssembler-mips32.cpp
@@ +1775,5 @@
>  
>  void
>  MacroAssemblerMIPSCompat::tagValue(JSValueType type, Register payload, ValueOperand dest)
>  {
> +    MOZ_ASSERT(dest.typeReg() != dest.payloadReg());

I feel like this assert may be superfluous... if we are getting the same payload and type register, wouldn't something else be horribly wrong?
Attachment #9010708 - Flags: review?(jitbugs) → review+
Keywords: checkin-needed
Pushed by aciure@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac7be31e4ad6
[MIPS] Make MacroAssemblerMIPSCompat::tagValue not assert if the payload is the same as output type register; r=froydnj
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ac7be31e4ad6
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.