Closed Bug 1492921 Opened 6 years ago Closed 6 years ago

[MIPS] Fix MacroAssemblerMIPS::ma_[add | sub]TestOverflow behavior when both input and output registers are the same.

Categories

(Core :: JavaScript Engine: JIT, enhancement)

63 Branch
Other
Linux
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: dragan.mladjenovic, Assigned: dragan.mladjenovic)

Details

Attachments

(1 file)

      No description provided.
Attached patch bug1492921.patchSplinter Review
Assignee: nobody → dragan.mladjenovic
Status: NEW → ASSIGNED
Attachment #9010713 - Flags: review?(jitbugs)
Comment on attachment 9010713 [details] [diff] [review]
bug1492921.patch

Review of attachment 9010713 [details] [diff] [review]:
-----------------------------------------------------------------

Reassigning review semi-randomly. Feel free to re-assign as needed.
Attachment #9010713 - Flags: review?(jitbugs) → review?(bbouvier)
Comment on attachment 9010713 [details] [diff] [review]
bug1492921.patch

Review of attachment 9010713 [details] [diff] [review]:
-----------------------------------------------------------------

Nathan applied for this review! (also feel free to reassign to :jitreviews)
Attachment #9010713 - Flags: review?(bbouvier) → review?(nfroyd)
Attachment #9010713 - Flags: review?(nfroyd) → review+
Keywords: checkin-needed
Pushed by aciure@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/27ba9965ff0a
[MIPS] Fix MacroAssemblerMIPS::ma_[add | sub]TestOverflow behavior when both input and output registers are the same ; r=froydnj
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/27ba9965ff0a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: