1492942 - ASR Snippets should respect onboarding, user pref

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Kate Hudson :k88hudson]

We need to make sure our snippets implementation does not conflict with onboarding "snippets" on the new tab page and respects the user-defined preference for snippets, i.e. if someone has turned off snippets in about:preferences#home, no snippets should show up.

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/5b7ff4cf033db4e142cd4d9a469c6321c8143c0f
Bug 1492942 - Snippets should respect onboarding, user pref

Comment 2

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/410ea4b30b37

Comment 3

[Kate Hudson :k88hudson]

To verify this, please try the following:

For the user preference:

1. First turn on ASRouter snippets by pasting the following code into the browser console:

Services.prefs.setStringPref(
  "browser.newtabpage.activity-stream.asrouter.messageProviders",
  JSON.stringify([{"id":"onboarding","type":"local","localProvider":"OnboardingMessageProvider","enabled":true,"cohort":1},{"id":"snippets","type":"remote","url":"https://snippets.cdn.mozilla.net/us-west/bundles/bundle_d6d90fb9098ce8b45e60acf601bcb91b68322309.json","updateCycleInMs":14400000,"enabled":true},{"id":"cfr","type":"local","localProvider":"CFRMessageProvider","enabled":true,"cohort":0}])
);

2. Ensure that snippets are visible on about:newtab
3. Turn off the user preference for snippets on about:preferences#home
4. Ensure snippets are no longer visible on about:newtab
5. Turn the preference back on
6. Ensure snippets are showing up again


For the onboarding conflict:

1. Create a new profile at set browser.onboarding.notification.mute-duration-on-first-session-ms to 0 in about:config.
2. Ensure onboarding messages show up on about:newtab.
3. Turn on ASRouter snippets using the code snippet in step 1 of the previous section;
4. Ensure snippets are NOT visible on about:newtab
5. Set browser.onboarding.notification.finished to true in about:config to simulate onboarding being finished.
6. Ensure snippets now show up on about:newtab

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest version of "Firefox Nightly" (64.0a1 - Build ID 20181003100127) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the "Snippets" are respecting the user-defined preferences and are not conflicting with the onboarding ones.

Comment 5

[Tim Spurway [:tspurway]]

This bug fixes bug #1503047 which appears to be a driver for a 63 point release