Closed Bug 1493017 Opened 2 years ago Closed 2 years ago

Update problemMatcher regex in vscode tasks.json to handle Windows output

Categories

(Firefox Build System :: General, defect)

x86_64
Windows 10
defect
Not set
normal

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: gerald, Assigned: gerald)

Details

Attachments

(1 file, 1 obsolete file)

As reported by :jya, clang errors on Linux and Mac look like this:
> /[...]/ffmpeg/FFmpegVideoDecoder.cpp:315:6: error: expected expression
While on Windows then look like this:
> c:/[...]/ffmpeg/FFmpegVideoDecoder.cpp(315,7): error: expected expression
Notice the difference in line&column format.

Strangely, vscode seems to still be able to jump to the correct line, but I'm told sometimes it doesn't work. So it would be nice to have a correct matcher for all our platforms.

vscode doesn't allow a different matcher per platform. This may change, see https://github.com/Microsoft/vscode/issues/59023 , but in the meantime it is possible to craft a single regex that handles both formats: https://regexr.com/3vscc
The original regex could match linux&mac outputs that look like:
`/[...]/ffmpeg/FFmpegVideoDecoder.cpp:315:6: error: expected expression`
However on Windows the same outputs have a different line&column format:
`c:/[...]/ffmpeg/FFmpegVideoDecoder.cpp(315,7): error: expected expression`
The original regex could match linux&mac outputs that look like:
`/[...]/ffmpeg/FFmpegVideoDecoder.cpp:315:6: error: expected expression`
However on Windows the same outputs have a different line&column format:
`c:/[...]/ffmpeg/FFmpegVideoDecoder.cpp(315,7): error: expected expression`
Attachment #9010797 - Attachment is obsolete: true
Comment on attachment 9010798 [details]
Bug 1493017 - Tweak vscode tasks.json problemMatcher regexes to handle clang/Windows output - r?jya

Jean-Yves Avenard [:jya] has approved the revision.
Attachment #9010798 - Flags: review+
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e0bbb4ea8ecb
Tweak vscode tasks.json problemMatcher regexes to handle clang/Windows output - r=jya
https://hg.mozilla.org/mozilla-central/rev/e0bbb4ea8ecb
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.