1493017 - Update problemMatcher regex in vscode tasks.json to handle Windows output

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

As reported by :jya, clang errors on Linux and Mac look like this:
> /[...]/ffmpeg/FFmpegVideoDecoder.cpp:315:6: error: expected expression
While on Windows then look like this:
> c:/[...]/ffmpeg/FFmpegVideoDecoder.cpp(315,7): error: expected expression
Notice the difference in line&column format.

Strangely, vscode seems to still be able to jump to the correct line, but I'm told sometimes it doesn't work. So it would be nice to have a correct matcher for all our platforms.

vscode doesn't allow a different matcher per platform. This may change, see https://github.com/Microsoft/vscode/issues/59023 , but in the meantime it is possible to craft a single regex that handles both formats: https://regexr.com/3vscc

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1493017 - Tweak vscode tasks.json problemMatcher regexes to handle clang/Windows output - r?jya

The original regex could match linux&mac outputs that look like:
`/[...]/ffmpeg/FFmpegVideoDecoder.cpp:315:6: error: expected expression`
However on Windows the same outputs have a different line&column format:
`c:/[...]/ffmpeg/FFmpegVideoDecoder.cpp(315,7): error: expected expression`

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1493017 - Tweak vscode tasks.json problemMatcher regexes to handle clang/Windows output - r?jya

The original regex could match linux&mac outputs that look like:
`/[...]/ffmpeg/FFmpegVideoDecoder.cpp:315:6: error: expected expression`
However on Windows the same outputs have a different line&column format:
`c:/[...]/ffmpeg/FFmpegVideoDecoder.cpp(315,7): error: expected expression`

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 9010798 [details]
Bug 1493017 - Tweak vscode tasks.json problemMatcher regexes to handle clang/Windows output - r?jya

Jean-Yves Avenard [:jya] has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0bbb4ea8ecb
Tweak vscode tasks.json problemMatcher regexes to handle clang/Windows output - r=jya

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/e0bbb4ea8ecb