Closed Bug 1493021 Opened Last year Closed Last year

Prevent test-coverage from running on non code coverage builds.

Categories

(Testing :: Code Coverage, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: sparky, Assigned: sparky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This bug is to prevent test-coverage from running on non code coverage builds like the builds shown in this push: https://treeherder.mozilla.org/#/jobs?repo=try&tier=1,2,3&group_state=expanded&searchStr=coverage&revision=e6cb90f1c87b707339c35cb514fa3600f3e3be44
This patch prevents the test-coverage task from running on builds that are not related to code coverage.
Here's a push with the correct tasks selected after these changes: https://treeherder.mozilla.org/#/jobs?repo=try&revision=23d23527e0e32c19ff36ddd8c0e279db255952b6
I wonder why the `run-on-projects` at https://dxr.mozilla.org/mozilla-central/rev/ac9f1219d11bf1a56ec1ace8e3ba9ff113b5cacb/taskcluster/ci/test/misc.yml#197 doesn't work anymore (or has it never worked?).

Ah, maybe it is because the try build was made with '--full'?

Anyway, if we make this change, maybe we don't need that run-on-projects anymore.
The 'run-on-projects' flag is very confusing IMO. When you set 'run-on-projects' to 'built-projects', it means that the task will be run on any projects (try, mozilla-central, etc.) that it's build is run in, so we still need it for that.
Also, before applying this patch, you can schedule test-coverage with |mach try fuzzy -q 'test-coverage'|. I used that command for this push, where the patch applied was incomplete/broken for windows: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a18ac22e0e1c00bfe00af03625b5da7fe6bbd88e
(In reply to Greg Mierzwinski [:sparky] from comment #4)
> The 'run-on-projects' flag is very confusing IMO. When you set
> 'run-on-projects' to 'built-projects', it means that the task will be run on
> any projects (try, mozilla-central, etc.) that it's build is run in, so we
> still need it for that.

In this case it is set to `built-projects` only for ccov though, and it is set to empty for all other builds. This is why we don't see it running on mozilla-central, inbound, try and so on by default.
When you specify "--full" though, I think run-on-projects is ignored.
I didn't read my commands properly, sorry. I think you're right, and that it's ignored with "--full" based on this: https://dxr.mozilla.org/mozilla-central/source/taskcluster/docs/attributes.rst#5-11

I see that the default is `built-projects` [1] so if we remove the `run-on-projects` calls we should be fine. What do you think? I'm wondering if this change could affect mozilla-central tasks.

[1]: https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/transforms/tests.py#187
Comment on attachment 9010803 [details]
Bug 1493021 - Prevent test-coverage from running on non code coverage builds. r?jmaher

Joel Maher ( :jmaher ) (UTC-4) has approved the revision.
Attachment #9010803 - Flags: review+
Blocks: 1493974
Pushed by gmierz2@outlook.com:
https://hg.mozilla.org/integration/autoland/rev/0c7fce04aecc
Prevent test-coverage from running on non code coverage builds. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/0c7fce04aecc
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.