Closed Bug 1493071 Opened Last year Closed Last year

bouncer check mistakenly runs as part of the push graph(s)

Categories

(Release Engineering :: Release Automation: Other, enhancement)

enhancement
Not set

Tracking

(firefox-esr60 fixed, firefox63 fixed, firefox64 fixed)

RESOLVED FIXED
Tracking Status
firefox-esr60 --- fixed
firefox63 --- fixed
firefox64 --- fixed

People

(Reporter: mtabara, Assigned: sfraser)

References

Details

(Whiteboard: [releaseduty])

Attachments

(1 file)

In bug 1469803 we added ability to run bouncer check on demand in order to improve the verification for bouncer products. We added it in 63 and for mozilla-central, AFAIK, it worked just fine, part of CI - triggered by a hook, twice a day (?). But when changes rode the trains and landed in beta, they added a new task within the push-phase. So now we ended up having the release-bouncer-check (formerly known uptake monitoring which is correctly placed there) and its counterpart sibling which is supposed to be part of the CI.

See Firefox example of push graph[1] with intruder task bouncer-check here[2]. See Devedition example of push graph[3] with intruder task bouncer-check here[4].

I suspect we've got some extra field or relpro flag turned on mistakenly in the taskgraphs.

[1]: https://tools.taskcluster.net/groups/CTU6CA-PTGyDBu4IExIgoA
[2]: https://tools.taskcluster.net/groups/CTU6CA-PTGyDBu4IExIgoA/tasks/SdOUo9M_RUqwPzBarAvSGQ/details
[3]: https://tools.taskcluster.net/groups/CTU6CA-PTGyDBu4IExIgoA
[4]: https://tools.taskcluster.net/groups/CTU6CA-PTGyDBu4IExIgoA/tasks/SdOUo9M_RUqwPzBarAvSGQ/details
Weirdly enough, I glanced over in https://tools.taskcluster.net/hooks/ and couldn't find the hook that I thought is triggering the bouncer-check.

@sfraser: did we change anything recently related to this check?
Flags: needinfo?(sfraser)
Note to self/sfraser: we should look into changing this task's name, sounds like it's confusing and went under the radar unnoticed for a couple of weeks in the beta-cycle because it has a name so similar to its father, release-bouncer-check.
Summary: bouncer check runs as part of the graph → bouncer check mistakenly runs as part of the push graph(s)
(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #1)
> Weirdly enough, I glanced over in https://tools.taskcluster.net/hooks/ and
> couldn't find the hook that I thought is triggering the bouncer-check.
> 
> @sfraser: did we change anything recently related to this check?

Wasn't it a cron using target tasks? https://dxr.mozilla.org/mozilla-central/source/.cron.yml#105-121

As for it being added to the graph, it might well be the mention of shipping-phase here https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/bouncer-check/kind.yml#16 

We can also rename it - perhaps cron-bouncer-check?
Flags: needinfo?(sfraser)
(In reply to Simon Fraser [:sfraser] ⌚️GMT from comment #3)
> (In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #1)
> > Weirdly enough, I glanced over in https://tools.taskcluster.net/hooks/ and
> > couldn't find the hook that I thought is triggering the bouncer-check.
> > 
> > @sfraser: did we change anything recently related to this check?
> 
> Wasn't it a cron using target tasks?
> https://dxr.mozilla.org/mozilla-central/source/.cron.yml#105-121

Ah, right! Forgot of the cronjobs for a second there, makes sense! :) 

> As for it being added to the graph, it might well be the mention of
> shipping-phase here
> https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/bouncer-check/
> kind.yml#16 

Quite possible indeed!
 
> We can also rename it - perhaps cron-bouncer-check?

I like this rename, it's more intuitive!
Comment on attachment 9011439 [details]
Bug 1493071 Rename bouncer_check cron task r=mtabara

Mihai Tabara [:mtabara]⌚️GMT has approved the revision.
Attachment #9011439 - Flags: review+
Pushed by sfraser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3c7a1fb33462
Rename bouncer_check cron task r=mtabara
Flags: needinfo?(sfraser)
Assignee: nobody → sfraser
Pushed by sfraser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a09f0857ea67
Rename bouncer_check cron task r=mtabara
https://hg.mozilla.org/mozilla-central/rev/a09f0857ea67
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
See Also: → 1492639
You need to log in before you can comment on or make changes to this bug.