1493120 - Tag breakage reports by what blocker was active on the page

Status: RESOLVED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Johann Hofmann [:johannh]]

To better filter out relevant reports when we ship this to more popular release channels such as Release or Beta, we want to tag reports by what kind of blocking occurred (FB, TP, CR)

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1493120 - Label breakage reports by active blocker. r=Ehsan

Comment 2

[(no longer active)]

Comment on attachment 9010903 [details]
Bug 1493120 - Label breakage reports by active blocker. r=Ehsan

:Ehsan Akhgari has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96a797627444
Label breakage reports by active blocker. r=Ehsan

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/96a797627444

Comment 5

[Johann Hofmann [:johannh]]

Comment on attachment 9010903 [details]
Bug 1493120 - Label breakage reports by active blocker. r=Ehsan

Sorry for the delay with this uplift request, I always meant to request it but now we need this patch to get uplifted for bug 1496557, as well.



[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: None, this simply helps our WebCompat team make more sense of release and beta data from content blocking breakage reports.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: This patch should have internal effects on breakage reports only.

List of other uplifts needed: Bug 1484761

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is a really simple patch that adds labels to a user-submitted breakage reports. It's covered with a test and has been baking in Nightly without issues for 2 weeks.

String changes made/needed: None

Comment 6

[Johann Hofmann [:johannh]]

(In reply to Johann Hofmann [:johannh] from comment #5)
> List of other uplifts needed: Bug 1484761

Sorry, I meant bug 1496557

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9010903 [details]
Bug 1493120 - Label breakage reports by active blocker. r=Ehsan

Uplift approved for 63 beta 14, thanks.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/55aa0ae41d99