1493142 - Use 7 final tag to build libcxx

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

https://bugzilla.mozilla.org/show_bug.cgi?id=1491788#c11

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1493142 - Use 7 final tag to build libcxx r?dmajor

Comment 2

[(Away)]

Comment on attachment 9010925 [details]
Bug 1493142 - Use 7 final tag to build libcxx r?dmajor

David Major [:dmajor] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98b7811a0bae
Use 7 final tag to build libcxx r=dmajor

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 9010925 [details]
Bug 1493142 - Use 7 final tag to build libcxx r?dmajor

Lazy cc from bug 1491788

Just like we did here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1489096#c8

Approval Request Comment
[Feature/Bug causing the regression]: There is no specific issue that is motivating this uplift.
[User impact if declined]: We ship our first clang-cl release with an rc release. even if rc3 == final, it is still less confusing for everyone to use a final release instead of a rc3
[Is this code covered by automated tests?]: all the tests!
[Has the fix been verified in Nightly?]: 1 day
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: Just like what we have in beta currently
[String changes made/needed]: no

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/98b7811a0bae

Comment 6

[(Away)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #4)
> [Has the fix been verified in Nightly?]: 1 day

This comment seems a bit hasty given that it was posted before the bug even reached m-c.

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9010925 [details]
Bug 1493142 - Use 7 final tag to build libcxx r?dmajor

Uplift approved for 63 beta 9, thanks.

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ae6e3d1a27dd