Closed Bug 1493142 Opened 4 years ago Closed 4 years ago

Use 7 final tag to build libcxx

Categories

(Firefox Build System :: Toolchains, defect)

defect
Not set
normal

Tracking

(firefox63 fixed, firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox63 --- fixed
firefox64 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(1 file)

Assignee: nobody → sledru
Comment on attachment 9010925 [details]
Bug 1493142 - Use 7 final tag to build libcxx r?dmajor

David Major [:dmajor] has approved the revision.
Attachment #9010925 - Flags: review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/98b7811a0bae
Use 7 final tag to build libcxx r=dmajor
Comment on attachment 9010925 [details]
Bug 1493142 - Use 7 final tag to build libcxx r?dmajor

Lazy cc from bug 1491788

Just like we did here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1489096#c8

Approval Request Comment
[Feature/Bug causing the regression]: There is no specific issue that is motivating this uplift.
[User impact if declined]: We ship our first clang-cl release with an rc release. even if rc3 == final, it is still less confusing for everyone to use a final release instead of a rc3
[Is this code covered by automated tests?]: all the tests!
[Has the fix been verified in Nightly?]: 1 day
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: Just like what we have in beta currently
[String changes made/needed]: no
Attachment #9010925 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/98b7811a0bae
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
(In reply to Sylvestre Ledru [:sylvestre] from comment #4)
> [Has the fix been verified in Nightly?]: 1 day

This comment seems a bit hasty given that it was posted before the bug even reached m-c.
Comment on attachment 9010925 [details]
Bug 1493142 - Use 7 final tag to build libcxx r?dmajor

Uplift approved for 63 beta 9, thanks.
Attachment #9010925 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.