Closed
Bug 1493173
Opened 6 years ago
Closed 6 years ago
Remove the unneeded dependency from win64-st-autotest/debug
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•6 years ago
|
||
Comment on attachment 9010944 [details] Bug 1493173 - Remove the unneeded dependency from win64-st-autotest/debug David Major [:dmajor] has approved the revision.
Attachment #9010944 -
Flags: review+
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ae99a39d6497 Remove the unneeded dependency from win64-st-autotest/debug r=dmajor
Comment 4•6 years ago
|
||
Backed out changeset ae99a39d6497 (Bug 1493173) for bustage on static-analysis autotest. Backout: https://hg.mozilla.org/integration/autoland/rev/4076423ea9133e3146ed01a249922da2a3c6b61c Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ae99a39d649760c62a7f83a729ff0a4a8c5cbfb5&selectedJob=200808011 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=200808011&repo=autoland&lineNumber=1488
Flags: needinfo?(ehsan)
Assignee | ||
Comment 5•6 years ago
|
||
Huh! Dustin, any idea what this error means? Did I do something wrong? Should I done this in a different way. I don't grok what happened. Thanks!
Flags: needinfo?(ehsan) → needinfo?(dustin)
Comment 6•6 years ago
|
||
The command runs `mach static-analysis autotest`[1] which uses clang-tidy[2]. Thus this is certainly not an unneeded dependency, as far as I can tell. [1] https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/mach_commands.py#1879-1971 [2] https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/mach_commands.py#1912
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(dustin)
Resolution: --- → INVALID
Assignee | ||
Comment 7•6 years ago
|
||
Aha, I see. Thanks! The patch that added that was r=gps, no wonder I had no idea. In the future, a r? or f? on patches that touch this infrastructure is appreciated, at least so that the static analysis peers can maintain some idea of how things fit together. Thanks!
You need to log in
before you can comment on or make changes to this bug.
Description
•