1493174 - mach ide visualstudio fails

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Matthias :Kammueller]

**Output**:
 0:00.87 Clobber not needed.
 0:00.88 Adding make options from None
    MOZ_OBJDIR=c:/mozilla-source/mozilla-central/obj-i686-pc-mingw32
    OBJDIR=c:/mozilla-source/mozilla-central/obj-i686-pc-mingw32
 0:00.93 c:\mozilla-build\bin\mozmake.EXE -f client.mk -s
 0:03.33 Elapsed: 0.00s; From dist/private: Kept 0 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:03.34 Elapsed: 0.00s; From dist/public: Kept 0 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:03.37 Elapsed: 0.03s; From dist/xpi-stage: Kept 62 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:03.90 Elapsed: 0.54s; From _tests: Kept 0 existing; Added/updated 1046; Removed 0 files and 0 directories.
 0:04.42 Elapsed: 1.05s; From dist/bin: Kept 0 existing; Added/updated 2428; Removed 0 files and 0 directories.
 0:05.32 Elapsed: 1.98s; From dist/include: Kept 0 existing; Added/updated 5498; Removed 0 files and 0 directories.
 0:07.88 force-cargo-library-build
 0:09.45 [0m[0m[1m[32m    Finished[0m release [optimized] target(s) in 1.35s
 0:16.43 force-cargo-program-build
 0:17.24 [0m[0m[1m[32m    Finished[0m release [optimized] target(s) in 0.61s
 0:28.97   adding: install.rdf (172 bytes security) (deflated 53%)
 0:29.09   adding: plugins/nptest.dll (172 bytes security) (deflated 45%)
 0:29.11   adding: plugins/npsecondtest.dll (172 bytes security) (deflated 45%)
 0:29.13   adding: plugins/npthirdtest.dll (172 bytes security) (deflated 45%)
 0:29.15   adding: plugins/npswftest.dll (172 bytes security) (deflated 45%)
 0:45.16 Processing config: c:\mozilla-build\nsis-3.01\nsisconf.nsh
 0:45.16 Processing script file: "maintenanceservice_installer.nsi" (ACP)
 0:45.49 Processed 1 file, writing output (x86-unicode):
 0:45.49 Output: "c:\mozilla-source\mozilla-central\obj-i686-pc-mingw32\browser\installer\windows\instgen\maintenanceservice_installer.exe"
 0:45.49 Install: 1 page (64 bytes), 1 section (2072 bytes), 552 instructions (15456 bytes), 718 strings (4448 bytes), 1 language table (210 bytes).
 0:45.49 Uninstall: 2 pages (192 bytes), 1 section (2072 bytes), 176 instructions (4928 bytes), 735 strings (6092 bytes), 1 language table (250 bytes).
 0:45.49 Using zlib compression.
 0:45.49 EXE header size:               64000 / 38912 bytes
 0:45.49 Install code:                  22694 / 22690 bytes
 0:45.49 Install data:                  11780 / 11788 bytes
 0:45.49 Uninstall code+data:           50986 / 50978 bytes
 0:45.49 CRC (0x14E267C7):                  4 / 4 bytes
 0:45.49 Total size:                   149464 / 124372 bytes (120.1%)
 0:54.83 tar: mozscreenshots/browser/chrome.manifest: time stamp 2018-09-21 10:01:24 is 0.053 s in the future
 0:54.84 tar: mozscreenshots/browser: time stamp 2018-09-21 10:01:24 is 0.045 s in the future
 0:54.84 tar: mozscreenshots/chrome.manifest: time stamp 2018-09-21 10:01:24 is 0.043 s in the future
 0:54.85 tar: mozscreenshots: time stamp 2018-09-21 10:01:24 is 0.035 s in the future
 0:55.70 Packaging [e-mail]...
 0:56.16 Packaging [e-mail]...
 0:56.43 Packaging [e-mail]...
 0:56.74 397 compiler warnings present.
 0:56.81 Overall system resources - Wall time: 56s; CPU: 0%; Read bytes: 0; Write bytes: 0; Read time: 0; Write time: 0
 0:56.83 Your build was successful!
To view resource usage of the build, run |mach resource-usage|.
To take your build for a test drive, run: |mach run|
For more information on what to do now, see https://developer.mozilla.org/docs/Developer_Guide/So_You_Just_Built_Firefox
 0:56.84 c:/mozilla-source/mozilla-central/obj-i686-pc-mingw32\_virtualenvs\init\Scripts\python.exe c:/mozilla-source/mozilla-central/obj-i686-pc-mingw32\config.status --backend=VisualStudio
Reticulating splines...
 0:02.87 File already read. Skipping: c:/mozilla-source/mozilla-central/gfx/angle/targets/angle_common/moz.build
 0:02.94 File already read. Skipping: c:/mozilla-source/mozilla-central/gfx/angle/targets/angle_common/moz.build
 0:02.95 File already read. Skipping: c:/mozilla-source/mozilla-central/gfx/angle/targets/angle_common/moz.build
 0:02.95 File already read. Skipping: c:/mozilla-source/mozilla-central/gfx/angle/targets/angle_common/moz.build
 0:02.95 File already read. Skipping: c:/mozilla-source/mozilla-central/gfx/angle/targets/translator/moz.build
 0:02.95 File already read. Skipping: c:/mozilla-source/mozilla-central/gfx/angle/targets/libGLESv2/moz.build
Finished reading 1931 moz.build files in 7.67s
Read 64 gyp files in parallel contributing 0.00s to total wall time
Processed into 9815 build config descriptors in 6.56s
VisualStudio backend executed in 1.84s
Generated Visual Studio solution at c:/mozilla-source/mozilla-central/obj-i686-pc-mingw32\msvc\mozilla.sln
Total wall time: 17.25s; CPU time: 17.25s; Efficiency: 100%; Untracked: 1.18s
Error running mach:

    ['ide', 'visualstudio']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

CalledProcessError: Command '[u'explorer.exe', u'c:/mozilla-source/mozilla-central/obj-i686-pc-mingw32\\msvc\\mozilla.sln']' returned non-zero exit status 1

  File "c:\mozilla-source\mozilla-central\python/mozbuild/mozbuild/backend/mach_commands.py", line 63, in eclipse
    process = subprocess.check_call(['explorer.exe', visual_studio_workspace_dir])
  File "c:\mozilla-build\python\lib\subprocess.py", line 190, in check_call
    raise CalledProcessError(retcode, cmd)




**Workaround**:
simply launch mozilla.sln in C:\mozilla-source\mozilla-central\obj-i686-pc-mingw32\msvc

Comment 1

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1493174 - Fix running Visual Studio using the mach ide command. r=#firefox-build-system-reviewers

There are two problems that this patch addresses:

1. The path to the VS solution file that we're using to launch it is malformed,
   because os.path.join is using backslash seperators, but we're passing it a
   path which already contains forward slash seperators, and mixing the two is
   not valid. This is preventing VS from being launched at all.
2. We're throwing if explorer.exe does not return 0 when we call it to launch
   VS, but explorer.exe always returns 1 when run this way, even if it
   succeeded, so we output a spurious exception to the console.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d33c07076ada
Fix running Visual Studio using the mach ide command. r=firefox-build-system-reviewers,mhentges

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/d33c07076ada