149319 - Saving mail messages crash mozilla.

Status: VERIFIED DUPLICATE of bug 135279

(MailNews Core :: Backend, defect, P2)

Description

[Shanmugavelu Shanmuganathan (gone)]

Mozilla crashes when I try to save any POP3 mail messages.
This happens with Mozilla 1.0RC3 and Mozilla 1.0 release.
This is a Tru64 UNIX only problem. Though it looks very 
similar to bug# 135279 it is not the same problem.

Comment 1

[Shanmugavelu Shanmuganathan (gone)]

Attachment: Fix to prevent mozilla from crashing.

Comment 2

[David :Bienvenu]

not a mail db issue - I believe Navin or ducarroz has a dup of this - -> Navin,
cc JF.

Comment 3

[Andrew Schultz]

keyword crash, severity=>critical

Comment 4

[Shanmugavelu Shanmuganathan (gone)]

Can I have r= and sr= for this fix.

Comment 5

[Navin Gupta]

In bug 135279 you say

>I see this problem on a Tru64 UNIX machine. When I try to save 
>mails the browser crashes. This happens with Mozilla 1.0 RC3
>and Mozilla 1.0 Release. However this works alright on the nightlies.

If the above is true then it is a dup ? right

Comment 6

[Jean-Francois Ducarroz]

Can you explain why does your patch fix the crash? What is the value of
aNumBytesInLine when the crash occurs?

Comment 7

[Shanmugavelu Shanmuganathan (gone)]

Initially I thought it was the same problem. Thats why I added
those comments in bug 135279. But this turns out to be a "64 bit" problem.
These two bugs cause the same effect but the causes are different. 

Comment 8

[Shanmugavelu Shanmuganathan (gone)]

When the crash occured aNumBytesInLine is "0"  in the expression

if (startOfLine[aNumBytesInLine-1] == '\r')

(ladebug) p aNumBytesInLine 
& 0
(ladebug) whatis aNumBytesInLine
PRUint32& aNumBytesInLine

Comment 9

[Andrew Schultz]

see bug 94734 comment 35 for why this is crashing.

Comment 10

[Jean-Francois Ducarroz]

If I correctly undertand, this is a problem on the branch only. The patch for
for 135279 which has been checked in the trunk should fix that as we test for
aNumBytesInLine > 0

+    if (m_eatCRLFs && m_lineToken == '\n' && aNumBytesInLine > 0 &&
startOfLine[aNumBytesInLine-1] == '\r') // Remove the CR in a CRLF sequence


Can you try that...

Comment 11

[Shanmugavelu Shanmuganathan (gone)]

This is true. This is fixed in the trunk as quoted in #5 from my earlier comment.
I am trying to get this in so that it gets picked up for 7.0 RTM automatically.
The fix for 135279  was considered as risky for Mozilla 1.0 branch. 

Comment 12

[Navin Gupta]

I think bug 135279 will be taken for RTM. marking dup

*** This bug has been marked as a duplicate of 135279 ***

Comment 13

[Sheela Ravindran]

vrfy dup