Closed Bug 1493248 Opened 11 months ago Closed 11 months ago

docShell instead of mDocShell in dom/base/Location.cpp#l173

Categories

(Core :: Document Navigation, enhancement, P2)

63 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: dragana, Assigned: dragana)

Details

Attachments

(1 file)

https://hg.mozilla.org/mozilla-central/annotate/tip/dom/base/Location.cpp#l173


  nsCOMPtr<nsIDocShell> docShell(do_QueryReferent(mDocShell));
  if (!mDocShell) {
    return NS_OK;
  }


just looking at the code it looks like a typo. Should this be 'if (docShell)?'
Comment on attachment 9011042 [details]
Bug 1493248 - Check for docShell instread on mDocShell, a typo. r=baku

Andrea Marchesini [:baku] has approved the revision.
Attachment #9011042 - Flags: review+
Keywords: checkin-needed
Assignee: nobody → dd.mozilla
Status: NEW → ASSIGNED
Priority: -- → P2
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/753cec0ea42c
Check for docShell instread on mDocShell, a typo. r=baku
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/753cec0ea42c
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.