1493248 - docShell instead of mDocShell in dom/base/Location.cpp#l173

Status: RESOLVED FIXED

(Core :: DOM: Navigation, enhancement, P2)

Description

[Dragana Damjanovic [:dragana]]

https://hg.mozilla.org/mozilla-central/annotate/tip/dom/base/Location.cpp#l173


  nsCOMPtr<nsIDocShell> docShell(do_QueryReferent(mDocShell));
  if (!mDocShell) {
    return NS_OK;
  }


just looking at the code it looks like a typo. Should this be 'if (docShell)?'

Comment 1

[Dragana Damjanovic [:dragana]]

Attachment: Bug 1493248 - Check for docShell instread on mDocShell, a typo. r=baku

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 9011042 [details]
Bug 1493248 - Check for docShell instread on mDocShell, a typo. r=baku

Andrea Marchesini [:baku] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/753cec0ea42c
Check for docShell instread on mDocShell, a typo. r=baku

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/753cec0ea42c