1493261 - Talos profiling does not symbolicate addresses from the XUL library on macOS

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Markus Stange [:mstange]]

Filing this bug about bug 1492096 comment 10:
> talos jobs on osx all failed to have symbols.

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&group_state=expanded&searchStr=talos,tp-p&tochange=b4f8cb6afab6ac2f647a17b8f20478afb332e517&fromchange=1e167ef58df92afd693b415023cb2aa65b92e465

Comment 1

[Markus Stange [:mstange]]

I believe this was broken by bug 1358818. I don't think bug 1358818 achieved what it set out to do and it should be backed out.

More specifically: Symbolication gets its symbols from three sources:
 (1) The crashreporter-symbols directory or zip file that was generated for the profiled build.
 (2) Fallback to the official Mozilla symbol server.
 (3) On Linux and macOS, fallback to local symbolication by running nm or dump_syms_mac.

If the crashreporter symbols path is a URL to a zip file, then (1) will make a connection to the server that hosts this zip file.
(2) makes a connection to the Mozilla symbol server.
(3) does not make a connection and just happens locally.

I believe bug 1358818 was filed about (2), but the patch in it ended up disabling (1).

Try push with backout to confirm: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a307933e749dba1308b273526f0e718f4b05f382

Comment 2

[Markus Stange [:mstange]]

I'm always happy to review patches that have to do with symbolication.

Comment 3

[Markus Stange [:mstange]]

(In reply to Markus Stange [:mstange] from comment #1)
> I believe this was broken by bug 1358818. I don't think bug 1358818 achieved
> what it set out to do and it should be backed out.
> 
> Try push with backout to confirm:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=a307933e749dba1308b273526f0e718f4b05f382

That fixes it. Example profile: https://perf-html.io/from-url/https%3A%2F%2Fqueue.taskcluster.net%2Fv1%2Ftask%2FL84pxPGzSgiIh33e0GNSdg%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_tp5o.zip/calltree/?file=profile_tp5o%2F163.com_pagecycle_1%2Fcycle_0.profile&globalTrackOrder=0-1-2-3&hiddenGlobalTracks=1-2&localTrackOrderByPid=1750-1-0~1751-0~&thread=4&v=3

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1493261 - Back out Bug 1493261 because it broke symbolication on non-Windows platforms. r?jmaher

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 9011239 [details]
Bug 1493261 - Back out Bug 1493261 because it broke symbolication on non-Windows platforms. r?jmaher

Joel Maher ( :jmaher ) (UTC-4) has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da42d772b73c
Back out Bug 1493261 because it broke symbolication on non-Windows platforms. r=jmaher

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/da42d772b73c

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Is this worth backporting to Beta?

Comment 9

[Markus Stange [:mstange]]

Probably not. Talos performance investigations usually happen on Nightly. This change only impacts developers, it has no effects on Firefox.