Closed
Bug 1493278
Opened 6 years ago
Closed 6 years ago
ChildDNSService::GetDNSRecordHashKey is doing unnecessary work
Categories
(Core :: Networking: DNS, enhancement, P3)
Core
Networking: DNS
Tracking
()
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: froydnj, Assigned: michal)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
1.06 KB,
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
This code: https://searchfox.org/mozilla-central/source/netwerk/dns/ChildDNSService.cpp#63-67 assigns the host, and then an origin attributes suffix to the hash key being constructed. Surely one of those is superfluous (probably the host assignment)?
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → michal.novotny
Priority: -- → P3
Whiteboard: [necko-triaged]
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #9014343 -
Flags: review?(valentin.gosu)
Updated•6 years ago
|
Attachment #9014343 -
Flags: review?(valentin.gosu) → review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cf579f097fff ChildDNSService::GetDNSRecordHashKey is doing unnecessary work. r=valentin
Keywords: checkin-needed
Comment 3•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cf579f097fff
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•