Closed Bug 1493278 Opened 1 year ago Closed 1 year ago

ChildDNSService::GetDNSRecordHashKey is doing unnecessary work

Categories

(Core :: Networking: DNS, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: froydnj, Assigned: michal)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

This code:

https://searchfox.org/mozilla-central/source/netwerk/dns/ChildDNSService.cpp#63-67

assigns the host, and then an origin attributes suffix to the hash key being constructed.  Surely one of those is superfluous (probably the host assignment)?
Assignee: nobody → michal.novotny
Priority: -- → P3
Whiteboard: [necko-triaged]
Attached patch fixSplinter Review
Attachment #9014343 - Flags: review?(valentin.gosu)
Attachment #9014343 - Flags: review?(valentin.gosu) → review+
Keywords: checkin-needed
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf579f097fff
ChildDNSService::GetDNSRecordHashKey is doing unnecessary work. r=valentin
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cf579f097fff
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.