Closed Bug 1493306 Opened Last year Closed 11 months ago
View Locale handling to use Locale List
46 bytes, text/x-phabricator-request
|Details | Review|
In bug 1486552 we added basic handling of system locales to GeckoView. In bug 1486552 comment 28 I documented a proposed change to handle locale list in line with our Gecko intl model: ``` It is always better to use a locale fallback chain over a single locale. In case there’s only one locale available, a list with one element will work while allowing for future extensions without a costly refactor. ``` I'd like to request to switch that new API to use OSPreferences to handle system locale management and use lists. It should follow the same logic that Fennnec's model uses with reacting to events and updating system locales in result. Then, the only setting needed is to set `intl.locale.requested` to an empty list which is used to indicate that the user wants OS locales to be their requested locales as per  This is how this is done for Fennec: https://searchfox.org/mozilla-central/source/mobile/android/installer/mobile-l10n.js#6  https://firefox-source-docs.mozilla.org/intl/locale.html#locale-fallback-chains  https://firefox-source-docs.mozilla.org/intl/locale.html#requested-locales
See Also: → 1486552
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/35920033f3d6 Make GeckoView setLocale API accept a locale list. r=snorp
Backout by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/b750cfc5a0fc Backed out changeset 35920033f3d6 for android build bustages on a CLOSED TREE
backed out for android build bustages Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=35920033f3d614ae90cca2fa120f6d254f143f52 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=211735851&repo=autoland&lineNumber=40758 Backout: https://hg.mozilla.org/integration/autoland/rev/b750cfc5a0fc392225d6e0c3892d6dceaa97b0d8
Pushed to try with fix for build bustage: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ac2999b53482ea6da13aab4b6beeec715fc9d72
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/ebf1f69c10ca Make GeckoView setLocale API accept a locale list. r=snorp
64=wontfix because this bug doesn't block Focus 8.0.
Depends on: 1508636
You need to log in before you can comment on or make changes to this bug.