1493335 - Perma Tier 2 Assertion failure: false (JS_GetProperty(cx, module, "float32"|"int32", &typeDescr)), at /builds/worker/workspace/build/src/js/src/builtin/TypedObject.cpp:1421

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: btara [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=200905461&repo=mozilla-central

https://queue.taskcluster.net/v1/task/fNCxOXG1RIOBSXW9NnEz6g/runs/0/artifacts/public/logs/live_backing.log

[task 2018-09-22T00:38:49.997Z] 00:38:49     INFO -  TEST-PASS | tests/jit-test/jit-test/tests/basic/bug1300904.js | Success (code 0, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads") [0.7 s]
[task 2018-09-22T00:38:49.997Z] 00:38:49     INFO -  {"action": "test_start", "jitflags": "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads", "pid": 24161, "source": "jittests", "test": "basic/bug1300904.js", "thread": "main", "time": 1537576729.326567}
[task 2018-09-22T00:38:49.997Z] 00:38:49     INFO -  {"action": "test_end", "extra": {"jitflags": "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads", "pid": 24161}, "jitflags": "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads", "message": "Success", "pid": 24161, "source": "jittests", "status": "PASS", "test": "basic/bug1300904.js", "thread": "main", "time": 1537576729.992409}
[task 2018-09-22T00:38:50.317Z] 00:38:50     INFO -  [CodeCoverage] Setting handlers for process 24163.
[task 2018-09-22T00:38:50.317Z] 00:38:50     INFO -  Assertion failure: false (JS_GetProperty(cx, module, "int32", &typeDescr)), at /builds/worker/workspace/build/src/js/src/builtin/TypedObject.cpp:1421
[task 2018-09-22T00:38:50.317Z] 00:38:50     INFO -  Exit code: -11
[task 2018-09-22T00:38:50.318Z] 00:38:50     INFO -  FAIL - basic/bug1300904.js
[task 2018-09-22T00:38:50.318Z] 00:38:50  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/basic/bug1300904.js | [CodeCoverage] Setting handlers for process 24163. (code -11, args "--baseline-eager") [0.6 s]
[task 2018-09-22T00:38:50.318Z] 00:38:50     INFO -  {"action": "test_start", "jitflags": "--baseline-eager", "pid": 24163, "source": "jittests", "test": "basic/bug1300904.js", "thread": "main", "time": 1537576729.7506}
[task 2018-09-22T00:38:50.318Z] 00:38:50     INFO -  {"action": "test_end", "extra": {"jitflags": "--baseline-eager", "pid": 24163}, "jitflags": "--baseline-eager", "message": "[CodeCoverage] Setting handlers for process 24163.", "pid": 24163, "source": "jittests", "status": "FAIL", "test": "basic/bug1300904.js", "thread": "main", "time": 1537576730.312519}
[task 2018-09-22T00:38:50.319Z] 00:38:50     INFO -  INFO exit-status     : -11
[task 2018-09-22T00:38:50.319Z] 00:38:50     INFO -  INFO timed-out       : False
[task 2018-09-22T00:38:50.319Z] 00:38:50     INFO -  INFO stderr         2> [CodeCoverage] Setting handlers for process 24163.
[task 2018-09-22T00:38:50.319Z] 00:38:50     INFO -  INFO stderr         2> Assertion failure: false (JS_GetProperty(cx, module, "int32", &typeDescr)), at /builds/worker/workspace/build/src/js/src/builtin/TypedObject.cpp:1421
[task 2018-09-22T00:38:50.339Z] 00:38:50     INFO -  TEST-PASS | tests/jit-test/jit-test/tests/basic/bug1301797.js | Success (code 0, args "") [0.3 s]

Comment 1

[Andreea Pavel [:apavel]]

This appears to be from Bug 1459900. Lars, can you take a look?

Comment 2

[Intermittent Failures Robot]

28 failures in 2902 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-central: 28

Platform breakdown:
* linux64-ccov: 20
* windows10-64-ccov: 8

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1493335&startday=2018-09-17&endday=2018-09-23&tree=all

Comment 4

[Lars T Hansen [:lth]]

Attachment: bug1493335-handle-oom.patch

Comment 5

[Intermittent Failures Robot]

25 failures in 439 pushes (0.057 failures/push) were associated with this bug yesterday.

Repository breakdown:
* mozilla-central: 25

Platform breakdown:
* linux64-ccov: 16
* windows10-64-ccov: 9

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1493335&startday=2018-09-24&endday=2018-09-24&tree=all

Comment 6

[Julian Seward [:jseward]]

Comment on attachment 9011434 [details] [diff] [review]
bug1493335-handle-oom.patch

Review of attachment 9011434 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine.

::: js/src/builtin/TypedObject.cpp
@@ +1418,5 @@
>  
>      RootedValue typeDescr(cx);
>  
> +    // The lookups should fail only from atomization-related OOM in
> +    // JS_GetProperty(), the properties should always be there.

Nit: kinda confusing run-on sentence.  Maybe ".. JS_GetProperty().  The properties themselves will always exist."

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8e30b10e75d
handle obscure oom path during initialization. r=jseward

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e8e30b10e75d

Comment 9

[Intermittent Failures Robot]

27 failures in 553 pushes (0.049 failures/push) were associated with this bug yesterday.

Repository breakdown:
* mozilla-central: 27

Platform breakdown:
* linux64-ccov: 18
* windows10-64-ccov: 9

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1493335&startday=2018-09-25&endday=2018-09-25&tree=all

Comment 10

[Intermittent Failures Robot]

52 failures in 2773 pushes (0.019 failures/push) were associated with this bug in the last 7 days.

This is the #41 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* mozilla-central: 52

Platform breakdown:
* linux64-ccov: 34
* windows10-64-ccov: 18

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1493335&startday=2018-09-24&endday=2018-09-30&tree=all