Closed Bug 1493368 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 13154 - [wptrunner] Fix support for `--binary-arg` in Fx

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox64 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 13154 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13154
Details from upstream follow.

Mike Pennisi <mike@mikepennisi.com> wrote:
>  [wptrunner] Fix support for `--binary-arg` in Fx
>  
>  In order to automate Firefox, wptrunner requires the browser's internal
>  module "Marionette" to be enabled. This is a requirement regardless of
>  any custom configuration specified by the user, including additional
>  command-line flags via the `--binary-arg` argument.
>  
>  Previously, this project would omit the `-marionette` argument in the
>  presence of any user-specified arguments. Because this interferes with
>  normal operation (and because the source code is formatted in a way that
>  conflicts with the order of operations), this is likely an unintentional
>  behavior.
>  
>  Modify the code which derives the command-line arguments to always
>  include the `-marionette` argument.
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/75d065357544
[wpt PR 13154] - [wptrunner] Fix support for `--binary-arg` in Fx, a=testonly
Result changes from PR not available.
https://hg.mozilla.org/mozilla-central/rev/75d065357544
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.