Open Bug 1493370 Opened 6 years ago Updated 2 years ago

[wpt-sync] Sync PR 13155 - Revert "bindings: Implement timers with V8Function"

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(Not tracked)

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream error])

Sync web-platform-tests PR 13155 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13155
Details from upstream follow.

Timothy Gu <timothygu@chromium.org> wrote:
>  Revert "bindings: Implement timers with V8Function"
>  
>  This reverts commit 254369a5f6df06c2c6be067d14c2cb2a036ba173.
>  
>  Reason for revert: This breaks ASAN.
>  
>  Bug: 888025
>  
>  Original change's description:
>  > bindings: Implement timers with V8Function
>  > 
>  > This fixes bug 866610 by using the IDL infrastructure to properly enter
>  > the v8::Context before calling the registered callback.
>  > 
>  > Also ensure eager finalization of ScheduledAction in DOMTimer to
>  > prevent a memory leak. Added two more effective DCHECKs to confirm.
>  > 
>  > Bug: 866610
>  > Change-Id: I37d7bd05f035fe31856cfe68bae51aa0632cd3b1
>  > Reviewed-on: https://chromium-review.googlesource.com/1220486
>  > Reviewed-by: Nate Chapin \<japhet@chromium.org>
>  > Reviewed-by: Yuki Shiino \<yukishiino@chromium.org>
>  > Reviewed-by: Hitoshi Yoshida \<peria@chromium.org>
>  > Commit-Queue: Timothy Gu \<timothygu@chromium.org>
>  > Cr-Commit-Position: refs/heads/master@{#593108}
>  
>  TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org,japhet@chromium.org,timothygu@chromium.org
>  
>  Change-Id: I814d9090fe61c98a39b01833606df4bcfe6d8b37
>  No-Presubmit: true
>  No-Tree-Checks: true
>  No-Try: true
>  Bug: 866610
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1239254
>  WPT-Export-Revision: 4b325f8bd1e77721f264cab184148af8837e928d
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.