1493418 - [regression] Garbled name for Simplified Chinese in Font Settings

Status: VERIFIED FIXED

(Core :: Layout: Text and Fonts, defect, P3)

Description

[YF (Yang)]

Attachment: Screenshot

STR:
1. Open about:preferences, click the Font & Color - Advanced button.
2. Select the "Simplified Chinese" for "Fonts for".


Actual results:
Fonts names (in Chinese) are garbled.


Expected results:
Regular Chinese name.


Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=643ffcb9063dfb9395c76d81665ed4cd03c0dff3&tochange=588fe70e5905480ebc60225b4b093ff276df72d2

Comment 1

[Jonathan Kew [:jfkthame]]

Ugh! Thanks for reporting, will look into it. Clearly we're missing a utf8/16 conversion somewhere.

Comment 2

[Jonathan Kew [:jfkthame]]

Which platform(s) are you seeing the bug on?

Comment 3

[YF (Yang)]

(In reply to Jonathan Kew (:jfkthame) from comment #2)
> Which platform(s) are you seeing the bug on?

Windows 10 (1803) x64.

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: nsThebesFontEnumerator needs to convert font names from UTF-8 (not Latin-1) to UTF-16

The 8-bit font names we're now using in thebes are utf-8; but unfortunately nsThebesFontEnumerator was applying ToNewUnicode to get a 16-bit string, and the 8-bit version of that function treats the input as Latin-1. So we need to use UTF8ToNewUnicode instead here.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed4b9b12e32a
nsThebesFontEnumerator needs to convert font names from UTF-8 (not Latin-1) to UTF-16. r=lsalzman

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ed4b9b12e32a

Comment 7

[YF (Yang)]

Fixed in 64.0a1 20180924220042.