1493421 - [wpt-sync] Sync PR 13166 - Reland "bindings: Implement timers with V8Function"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 13166 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13166
Details from upstream follow.

Timothy Gu <[e-mail]> wrote:
>  Reland "bindings: Implement timers with V8Function"
>  
>  This is a reland of 254369a5f6df06c2c6be067d14c2cb2a036ba173
>  
>  Original change's description:
>  > bindings: Implement timers with V8Function
>  > 
>  > This fixes bug 866610 by using the IDL infrastructure to properly enter
>  > the v8::Context before calling the registered callback.
>  > 
>  > Also ensure eager finalization of ScheduledAction in DOMTimer to
>  > prevent a memory leak. Added two more effective DCHECKs to confirm.
>  > 
>  > Bug: 866610
>  > Change-Id: I37d7bd05f035fe31856cfe68bae51aa0632cd3b1
>  > Reviewed-on: https://chromium-review.googlesource.com/1220486
>  > Reviewed-by: Nate Chapin \<[e-mail]>
>  > Reviewed-by: Yuki Shiino \<[e-mail]>
>  > Reviewed-by: Hitoshi Yoshida \<[e-mail]>
>  > Commit-Queue: Timothy Gu \<[e-mail]>
>  > Cr-Commit-Position: refs/heads/master@{#593108}
>  
>  Bug: 866610
>  Change-Id: Iee5c1d6917ad7770383e06a425f96000835a663a
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1239624
>  WPT-Export-Revision: 68e4eca995d2880d3dca9e0dd5d88e7de11665f9

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=d98335ab20e235538e6fed55d4b5ab7d01534d6b

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f93ccd88f2060e263f7bb0aa2618ad106837095

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=b451052654ccdac6600de29ef965408935c49233

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=525da9f2bdddedf9f2ba458b2626a07e6d3c04b9

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d7688c58bbaa9dd3d36babf5e8d63454fac129e

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e78e26c858ca127783be9d1bf741bc642e7196e3

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b0158c1d01cadcb13b77f5bab3eb63d6e83cd59

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2bd16a07cb924e541102ba66d7a8b32248f8efa2

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 1 tests and 1 subtests
OK     : 1
PASS   : 1

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8f6cb92b3a9
[wpt PR 13166] - Reland "bindings: Implement timers with V8Function", a=testonly

Comment 11

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/d8f6cb92b3a9