Closed Bug 1493421 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 13166 - Reland "bindings: Implement timers with V8Function"

Categories

(Core :: DOM: Core & HTML, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 13166 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13166
Details from upstream follow.

Timothy Gu <timothygu@chromium.org> wrote:
>  Reland "bindings: Implement timers with V8Function"
>  
>  This is a reland of 254369a5f6df06c2c6be067d14c2cb2a036ba173
>  
>  Original change's description:
>  > bindings: Implement timers with V8Function
>  > 
>  > This fixes bug 866610 by using the IDL infrastructure to properly enter
>  > the v8::Context before calling the registered callback.
>  > 
>  > Also ensure eager finalization of ScheduledAction in DOMTimer to
>  > prevent a memory leak. Added two more effective DCHECKs to confirm.
>  > 
>  > Bug: 866610
>  > Change-Id: I37d7bd05f035fe31856cfe68bae51aa0632cd3b1
>  > Reviewed-on: https://chromium-review.googlesource.com/1220486
>  > Reviewed-by: Nate Chapin \<japhet@chromium.org>
>  > Reviewed-by: Yuki Shiino \<yukishiino@chromium.org>
>  > Reviewed-by: Hitoshi Yoshida \<peria@chromium.org>
>  > Commit-Queue: Timothy Gu \<timothygu@chromium.org>
>  > Cr-Commit-Position: refs/heads/master@{#593108}
>  
>  Bug: 866610
>  Change-Id: Iee5c1d6917ad7770383e06a425f96000835a663a
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1239624
>  WPT-Export-Revision: 68e4eca995d2880d3dca9e0dd5d88e7de11665f9
Component: web-platform-tests → DOM
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 1 tests and 1 subtests
OK     : 1
PASS   : 1
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8f6cb92b3a9
[wpt PR 13166] - Reland "bindings: Implement timers with V8Function", a=testonly
https://hg.mozilla.org/mozilla-central/rev/d8f6cb92b3a9
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.