[wpt-sync] Sync PR 13176 - Module scripts use same-origin credentials mode by default

RESOLVED FIXED in Firefox 64

Status

()

enhancement
P4
normal
RESOLVED FIXED
9 months ago
3 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

unspecified
mozilla64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

(Whiteboard: [wptsync downstream], )

Assignee

Description

9 months ago
Sync web-platform-tests PR 13176 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13176
Details from upstream follow.

Dominic Farolino <domfarolino@gmail.com> wrote:
>  Module scripts use same-origin credentials mode by default
>  
>  Before this CL, module scripts via \<script type=module> used "omit" as
>  the default credentials mode. After this CL, "same-origin" is used. This
>  extends to module script descendants as well. Intent to implement and
>  ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/CUAxbvtnCh4.
>  
>  R=kinuko@chromium.org, kouhei@chromium.org, nhiroki@chromium.org
>  
>  Bug: 849101
>  Change-Id: I62617aafd3e226bc86459ec4a24138d9eac6e8ff
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1239638
>  WPT-Export-Revision: 4dd4f5dcad71354ad6120486198bb72b2c91df8c
Assignee

Updated

9 months ago
Component: web-platform-tests → DOM
Product: Testing → Core
Assignee

Comment 8

9 months ago
Ran 1 tests and 1 subtests
OK     : 1
FAIL   : 1

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/html/semantics/scripting-1/the-script-element/module/credentials.sub.html
    Modules should be loaded with or without the credentials based on the same-origin-ness and the crossOrigin attribute: FAIL

Comment 9

8 months ago
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/11c1ccfe8123
[wpt PR 13176] - Module scripts use same-origin credentials mode by default, a=testonly

Comment 10

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/11c1ccfe8123
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.