Closed Bug 1493508 Opened Last year Closed Last year

Port bug 1473736 - implement nsLDAPConnection::OnLookupByTypeComplete()

Categories

(MailNews Core :: LDAP Integration, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 64.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

Details

Attachments

(1 file)

Windows error:

10:33:57     INFO -  lld-link.exe: error: undefined symbol: ?OnLookupByTypeComplete@nsLDAPConnection@@UAG?AW4nsresult@@PAVnsICancelable@@PAVnsIDNSByTypeRecord@@W42@@Z
10:33:57     INFO -  >>> referenced by ..\..\comm\ldap\xpcom\src\nsLDAPConnection.obj:(??_7nsLDAPConnection@@6BnsIDNSListener@@@)
10:33:57     INFO -  z:/task_1537695954/build/src/config/rules.mk:708: recipe for target 'xul.dll' failed

Mac error:
10:26:53     INFO -  Undefined symbols for architecture x86_64:
10:26:53     INFO -    "__ZN16nsLDAPConnection22OnLookupByTypeCompleteEP13nsICancelableP18nsIDNSByTypeRecord8nsresult", referenced from:
10:26:53     INFO -        __ZTV16nsLDAPConnection in nsLDAPConnection.o
10:26:53     INFO -    "__ZThn24_N16nsLDAPConnection22OnLookupByTypeCompleteEP13nsICancelableP18nsIDNSByTypeRecord8nsresult", referenced from:
10:26:53     INFO -        __ZTV16nsLDAPConnection in nsLDAPConnection.o
10:26:53     INFO -  ld: symbol(s) not found for architecture x86_64
10:26:53     INFO -  clang-6.0: error: linker command failed with exit code 1 (use -v to see invocation)

Even on a Sunday :-(
Summary: Bustage from Bug 1473736 - something with nsIDNSByTypeRecord → Port bug 1473736 - implement nsLDAPConnection::OnLookupByTypeComplete()
Dragana, looks like OnLookupByTypeComplete() is not mandatory for classed implementing nsIDNSListener like our LDAP connection here.

I've copied a very simple one form here to fix the build bustage:
https://hg.mozilla.org/mozilla-central/rev/52ee9ddf5060#l49.13

Can you please tell me what needs to be done exactly.
Assignee: nobody → jorgk
Attachment #9011277 - Flags: feedback?(dd.mozilla)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/781c9a24b953
Port bug 1473736: implement nsLDAPConnection::OnLookupByTypeComplete(). rs=bustage-fix DONTBUILD
Comment on attachment 9011277 [details] [diff] [review]
1493508-OnLookupByTypeComplete.patch

Review of attachment 9011277 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good.

For implementation reason it was much much easier to add OnLookupByTypeComplete to nsIDNSListener instead of making a sepparate listener.
Attachment #9011277 - Flags: feedback?(dd.mozilla) → feedback+
OK, we'll leave it as landed then, thanks.
Status: NEW → RESOLVED
Closed: Last year
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 64.0
Type: defect → task
You need to log in before you can comment on or make changes to this bug.