1493646 - Browser toolbox shortcut closes the regular toolbox

Status: RESOLVED FIXED

(DevTools :: General, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

**Steps to reproduce**
1. Open the console
2. Hit the browser toolbox shortcut (Shift + Alt + Cmd + I on OSX)

**Expected results**

The browser toolbox opens

**Actual results**

The browser toolbox does not open and the regular toolbox is closed

---

Comment 1

[Brian Grinstead [:bgrins]]

My best guess without having looked into this is that `CmdOrCtrl+Alt+I` is being matched by the cmd+shift+opt+i shortcut to open BT which is causing `onClose` to fire https://searchfox.org/mozilla-central/rev/0640ea80fbc8d48f8b197cd363e2535c95a15eb3/devtools/client/framework/toolbox.js#930. It looks like there's some special casing for when the shiftKey doesn't match on OSX: https://searchfox.org/mozilla-central/rev/0640ea80fbc8d48f8b197cd363e2535c95a15eb3/devtools/client/shared/key-shortcuts.js#225-234.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e44b335346f52115d1d4c8f0796e5336f5da694

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks Brian for the pointer, that make sense.

The issue is that the keydown event object says `event.key == "ˆ"` while the code would rather expect `event.key == "I"` - where the code is the condition that checks whether the key is alphanumeric. Apparently not.

I added a new condition that also checks the `event.keyCode`.
It's not nice, but I am not seeing better solution.

Honza

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1493646 - Browser toolbox shortcut closes the regular toolbox; r=bgrins

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ede9011eb4506e5bdf425d97ce428a0947b40c2

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=06af0cdb2e7a6830a85afc23f9e7b74c50837b82

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae757626c524
Browser toolbox shortcut closes the regular toolbox; r=jdescottes

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ae757626c524