Closed Bug 1493668 Opened 3 years ago Closed 3 years ago

Change UrlbarInput unit test to be a mochitest for easier setup

Categories

(Firefox :: Address Bar, task, P1)

task

Tracking

()

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Per discussion in bug 1491252 we should change the existing test_UrlbarInput_unit.js from xpcshell to mochitest. This is so that we can easily pass elements as parameters to UrlbarInput and avoid the need for complex fake element objects.

This will still allow us to stub/mock as necessary for unit test needs, just with much easier setup.
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/92076b801e6b
Change UrlbarInput unit test to be a mochitest for easier setup. r=dao
Comment on attachment 9011450 [details]
Bug 1493668 - Change UrlbarInput unit test to be a mochitest for easier setup.

Dão Gottwald [::dao] has approved the revision.
Attachment #9011450 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/92076b801e6b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
See Also: → 1569027
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.