1493708 - Assertion failure: frame == aAncestor, at /builds/worker/workspace/build/src/layout/generic/nsFrame.cpp:2635

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[Jason Kratzer [:jkratzer]]

Attachment: testcase.html

Testcase found while fuzzing mozilla-central rev 095ec59a8800.


Assertion failure: frame == aAncestor, at /builds/worker/workspace/build/src/layout/generic/nsFrame.cpp:2635

rax = 0x0000000000000000   rdx = 0x0000000000000000
rcx = 0x0000000000000b40   rbx = 0x00007fcd75e70000
rsi = 0x00007fcd8fdf78b0   rdi = 0x00007fcd8fdf6680
rbp = 0x00007fff40e6d180   rsp = 0x00007fff40e6cc40
r8 = 0x00007fcd8fdf78b0    r9 = 0x00007fcd90f6f740
r10 = 0x0000000000000000   r11 = 0x0000000000000000
r12 = 0x00007fcd75e1aaa0   r13 = 0x0000000000000001
r14 = 0x0000000000000000   r15 = 0x00007fcd75e7ce48
rip = 0x00007fcd808d31e6
OS|Linux|0.0.0 Linux 4.15.0-34-generic #37-Ubuntu SMP Mon Aug 27 15:21:48 UTC 2018 x86_64
CPU|amd64|family 6 model 78 stepping 3|1
GPU|||
Crash|SIGSEGV /SEGV_MAPERR|0x0|0
0|0|libxul.so|nsIFrame::BuildDisplayListForStackingContext(nsDisplayListBuilder*, nsDisplayList*, bool*)|hg:hg.mozilla.org/mozilla-central:gfx/thebes/gfxPrefs.h:095ec59a8800360154df6668394803e5a84d031c|694|0x21
0|1|libxul.so|nsIFrame::BuildDisplayListForChild(nsDisplayListBuilder*, nsIFrame*, nsDisplayListSet const&, unsigned int)|hg:hg.mozilla.org/mozilla-central:layout/generic/nsFrame.cpp:095ec59a8800360154df6668394803e5a84d031c|3721|0x15
0|2|libxul.so|DisplayLine|hg:hg.mozilla.org/mozilla-central:layout/generic/nsBlockFrame.cpp:095ec59a8800360154df6668394803e5a84d031c|6770|0x19
0|3|libxul.so|nsBlockFrame::BuildDisplayList(nsDisplayListBuilder*, nsDisplayListSet const&)|hg:hg.mozilla.org/mozilla-central:layout/generic/nsBlockFrame.cpp:095ec59a8800360154df6668394803e5a84d031c|6865|0x33
0|4|libxul.so|nsIFrame::BuildDisplayListForChild(nsDisplayListBuilder*, nsIFrame*, nsDisplayListSet const&, unsigned int)|hg:hg.mozilla.org/mozilla-central:layout/generic/nsFrame.cpp:095ec59a8800360154df6668394803e5a84d031c|3759|0x17
0|5|libxul.so|nsColumnSetFrame::BuildDisplayList(nsDisplayListBuilder*, nsDisplayListSet const&)|hg:hg.mozilla.org/mozilla-central:layout/generic/nsColumnSetFrame.cpp:095ec59a8800360154df6668394803e5a84d031c|1288|0x1c
0|6|libxul.so|nsIFrame::BuildDisplayListForStackingContext(nsDisplayListBuilder*, nsDisplayList*, bool*)|hg:hg.mozilla.org/mozilla-central:layout/generic/nsFrame.cpp:095ec59a8800360154df6668394803e5a84d031c|3055|0x16
0|7|libxul.so|nsIFrame::BuildDisplayListForChild(nsDisplayListBuilder*, nsIFrame*, nsDisplayListSet const&, unsigned int)|hg:hg.mozilla.org/mozilla-central:layout/generic/nsFrame.cpp:095ec59a8800360154df6668394803e5a84d031c|3721|0x15
0|8|libxul.so|nsCanvasFrame::BuildDisplayList(nsDisplayListBuilder*, nsDisplayListSet const&)|hg:hg.mozilla.org/mozilla-central:layout/generic/nsCanvasFrame.cpp:095ec59a8800360154df6668394803e5a84d031c|651|0x18
0|9|libxul.so|nsIFrame::BuildDisplayListForChild(nsDisplayListBuilder*, nsIFrame*, nsDisplayListSet const&, unsigned int)|hg:hg.mozilla.org/mozilla-central:layout/generic/nsFrame.cpp:095ec59a8800360154df6668394803e5a84d031c|3759|0x17
0|10|libxul.so|mozilla::ScrollFrameHelper::BuildDisplayList(nsDisplayListBuilder*, nsDisplayListSet const&)|hg:hg.mozilla.org/mozilla-central:layout/generic/nsGfxScrollFrame.cpp:095ec59a8800360154df6668394803e5a84d031c|3702|0x1a
0|11|libxul.so|nsIFrame::BuildDisplayListForChild(nsDisplayListBuilder*, nsIFrame*, nsDisplayListSet const&, unsigned int)|hg:hg.mozilla.org/mozilla-central:layout/generic/nsFrame.cpp:095ec59a8800360154df6668394803e5a84d031c|3759|0x17
0|12|libxul.so|mozilla::ViewportFrame::BuildDisplayList(nsDisplayListBuilder*, nsDisplayListSet const&)|hg:hg.mozilla.org/mozilla-central:layout/generic/ViewportFrame.cpp:095ec59a8800360154df6668394803e5a84d031c|66|0x11
0|13|libxul.so|nsIFrame::BuildDisplayListForStackingContext(nsDisplayListBuilder*, nsDisplayList*, bool*)|hg:hg.mozilla.org/mozilla-central:layout/generic/nsFrame.cpp:095ec59a8800360154df6668394803e5a84d031c|3055|0x16
0|14|libxul.so|nsLayoutUtils::PaintFrame(gfxContext*, nsIFrame*, nsRegion const&, unsigned int, nsDisplayListBuilderMode, nsLayoutUtils::PaintFrameFlags)|hg:hg.mozilla.org/mozilla-central:layout/base/nsLayoutUtils.cpp:095ec59a8800360154df6668394803e5a84d031c|3709|0x5
0|15|libxul.so|mozilla::PresShell::Paint(nsView*, nsRegion const&, unsigned int)|hg:hg.mozilla.org/mozilla-central:layout/base/PresShell.cpp:095ec59a8800360154df6668394803e5a84d031c|6345|0x17
0|16|libxul.so|nsViewManager::ProcessPendingUpdatesPaint(nsIWidget*)|hg:hg.mozilla.org/mozilla-central:view/nsViewManager.cpp:095ec59a8800360154df6668394803e5a84d031c|480|0x28
0|17|libxul.so|nsViewManager::ProcessPendingUpdatesForView(nsView*, bool)|hg:hg.mozilla.org/mozilla-central:view/nsViewManager.cpp:095ec59a8800360154df6668394803e5a84d031c|412|0xd
0|18|libxul.so|nsViewManager::ProcessPendingUpdates()|hg:hg.mozilla.org/mozilla-central:view/nsViewManager.cpp:095ec59a8800360154df6668394803e5a84d031c|1102|0x11
0|19|libxul.so|nsRefreshDriver::Tick(mozilla::TimeStamp)|hg:hg.mozilla.org/mozilla-central:layout/base/nsRefreshDriver.cpp:095ec59a8800360154df6668394803e5a84d031c|2046|0x8
0|20|libxul.so|mozilla::RefreshDriverTimer::TickRefreshDrivers(mozilla::TimeStamp, nsTArray<RefPtr<nsRefreshDriver> >&)|hg:hg.mozilla.org/mozilla-central:layout/base/nsRefreshDriver.cpp:095ec59a8800360154df6668394803e5a84d031c|325|0x8
0|21|libxul.so|mozilla::RefreshDriverTimer::Tick(mozilla::TimeStamp)|hg:hg.mozilla.org/mozilla-central:layout/base/nsRefreshDriver.cpp:095ec59a8800360154df6668394803e5a84d031c|318|0xc
0|22|libxul.so|mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::TickRefreshDriver(mozilla::TimeStamp)|hg:hg.mozilla.org/mozilla-central:layout/base/nsRefreshDriver.cpp:095ec59a8800360154df6668394803e5a84d031c|756|0xc
0|23|libxul.so|mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::NotifyVsync(mozilla::TimeStamp)|hg:hg.mozilla.org/mozilla-central:layout/base/nsRefreshDriver.cpp:095ec59a8800360154df6668394803e5a84d031c|572|0xc
0|24|libxul.so|mozilla::layout::VsyncChild::RecvNotify(mozilla::TimeStamp const&)|hg:hg.mozilla.org/mozilla-central:layout/ipc/VsyncChild.cpp:095ec59a8800360154df6668394803e5a84d031c|78|0x9
0|25|libxul.so|mozilla::layout::PVsyncChild::OnMessageReceived(IPC::Message const&)|s3:gecko-generated-sources:2c36fa176485b987fd1c1ce548d1f34c4c8bfdea36ff5dd016400feb13d3c5c0c7f99d5a56d13733937c9483a48617af010c09f521533a5ce0fc1f74c50b86a2/ipc/ipdl/PVsyncChild.cpp:|167|0xc
0|26|libxul.so|mozilla::ipc::MessageChannel::DispatchAsyncMessage(IPC::Message const&)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessageChannel.cpp:095ec59a8800360154df6668394803e5a84d031c|2248|0x6
0|27|libxul.so|mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessageChannel.cpp:095ec59a8800360154df6668394803e5a84d031c|2175|0xb
0|28|libxul.so|mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::MessageChannel::MessageTask&)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessageChannel.cpp:095ec59a8800360154df6668394803e5a84d031c|2012|0xb
0|29|libxul.so|mozilla::ipc::MessageChannel::MessageTask::Run()|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessageChannel.cpp:095ec59a8800360154df6668394803e5a84d031c|2045|0xc
0|30|libxul.so|nsThread::ProcessNextEvent(bool, bool*)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThread.cpp:095ec59a8800360154df6668394803e5a84d031c|1166|0x15
0|31|libxul.so|NS_ProcessNextEvent(nsIThread*, bool)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.cpp:095ec59a8800360154df6668394803e5a84d031c|519|0x11
0|32|libxul.so|mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:095ec59a8800360154df6668394803e5a84d031c|97|0xa
0|33|libxul.so|MessageLoop::RunInternal()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:095ec59a8800360154df6668394803e5a84d031c|325|0x17
0|34|libxul.so|MessageLoop::Run()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:095ec59a8800360154df6668394803e5a84d031c|318|0x8
0|35|libxul.so|nsBaseAppShell::Run()|hg:hg.mozilla.org/mozilla-central:widget/nsBaseAppShell.cpp:095ec59a8800360154df6668394803e5a84d031c|158|0xd
0|36|libxul.so|XRE_RunAppShell()|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:095ec59a8800360154df6668394803e5a84d031c|939|0x11
0|37|libxul.so|mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:095ec59a8800360154df6668394803e5a84d031c|269|0x5
0|38|libxul.so|MessageLoop::RunInternal()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:095ec59a8800360154df6668394803e5a84d031c|325|0x17
0|39|libxul.so|MessageLoop::Run()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:095ec59a8800360154df6668394803e5a84d031c|318|0x8
0|40|libxul.so|XRE_InitChildProcess(int, char**, XREChildData const*)|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:095ec59a8800360154df6668394803e5a84d031c|765|0x8
0|41|firefox-bin|content_process_main(mozilla::Bootstrap*, int, char**)|hg:hg.mozilla.org/mozilla-central:ipc/contentproc/plugin-container.cpp:095ec59a8800360154df6668394803e5a84d031c|50|0x14
0|42|firefox-bin|main|hg:hg.mozilla.org/mozilla-central:browser/app/nsBrowserApp.cpp:095ec59a8800360154df6668394803e5a84d031c|287|0x11
0|43|libc-2.27.so||||0x21b97
0|44|firefox-bin|MOZ_ReportAssertionFailure|hg:hg.mozilla.org/mozilla-central:mfbt/Assertions.h:095ec59a8800360154df6668394803e5a84d031c|164|0x5

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Looks related to the recent changes I did to preserve-3d. Will take a look.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Handle split frames properly in FrameParticipatesIn3DContext. r=mattwoodrow

We're traversing primary frames, which are first continuations, so we can't
start from a continuation and expect to get to it. Add an assertion that would
catch further fishyness.

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 9011495 [details]
Handle split frames properly in FrameParticipatesIn3DContext. r=mattwoodrow

Matt Woodrow (:mattwoodrow) has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf7f7c91c8dd
Handle split frames properly in FrameParticipatesIn3DContext. r=mattwoodrow

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/cf7f7c91c8dd