1493785 - Raptor gdocs is failing on autoland

Status: RESOLVED FIXED

(Testing :: Raptor, defect)

Description

[Robert Wood [:rwood]]

Raptor gdocs pageload test is failing on mozilla autoland, as/of this landing:

https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=gdocs&revision=6c5b95f8154e63b67542892a8431370e5ee58b6a

Comment 1

[Robert Wood [:rwood]]

Hi Matthew,

I * believe * your patches that landed in Bug 1488786 may have broken the Raptor gdocs performance test [1] on autoland tier2.

The Raptor web extension measures hero elements/attributes that are in the test pages. Raptor uses 'querySelectorAll' and 'getAtrribute' to retrieve hero elements in the page, and uses IntersectionObserver to determine when the elements have been loaded [2].

Looks like the patches in Bug 1488786 make some changes when getting elements? Would you mind having a look please, to see if this did indeed break Raptor? Thanks!

[1] https://wiki.mozilla.org/Performance_sheriffing/Raptor

[2] https://searchfox.org/mozilla-central/rev/0640ea80fbc8d48f8b197cd363e2535c95a15eb3/testing/raptor/webext/raptor/measure.js#92

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

I grabbed the build, and the tab totally crashes when loading that raptor test. I've requested backout because that's probably going to break nightly anyhow.

I'll see what's wrong with the patch next!

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

(To clarify slight: Just visiting the URL, w/o any raptor extension is sufficient to crash the tab, so it's definitely worth backing out)

Comment 4

[Robert Wood [:rwood]]

(In reply to Matthew Gaudet (he/him) [:mgaudet] from comment #3)
> (To clarify slight: Just visiting the URL, w/o any raptor extension is
> sufficient to crash the tab, so it's definitely worth backing out)

Ah - ok, thanks Matthew!

Comment 5

[Robert Wood [:rwood]]

Note - there was a similar crash in production raptor gdocs before (Bug 1491966) - not sure if that's related in any way. That one was since fixed in production by a backout of a different bug, but I was still seeing it locally for some reason. Unsure if it's related at all.

[1] https://docs.google.com/document/d/1US-07msg12slQtI_xchzYxcKlTs6Fp7WqIc6W5GK5M8/edit?usp=sharing

Comment 6

[Matthew Gaudet (he/him) [:mgaudet]]

I don't think it would be related to this particular patch, however, it's possible there's an underlying bug that my patch exposed much more reliably. Still investigating. 

One thing I'd suggest if you haven't tried yet is doing some Raptor runs with debug builds. AFAICT that's not happening (though I could miss it), but if you did that some 'generic' crashes get better debug output (ie, see Bug 1488786, Comment #10).

Comment 7

[Matthew Gaudet (he/him) [:mgaudet]]

(Can we mark this as fixed by the backout?)

Comment 8

[Robert Wood [:rwood]]

(In reply to Matthew Gaudet (he/him) [:mgaudet] from comment #7)
> (Can we mark this as fixed by the backout?)

Thanks Matthew yes I see it's green again on autoland, great thanks for the backout. re: debug builds, for Bug 1491966 I did run on a local nightly debug build on OSX but still didn't get a full stack for some reason, I'm going to pull and build the latest now and see how it looks.