1493798 - Revert some changes to bug 1471165

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P2)

Description

[Jean-Yves Avenard [:jya]]

In bug 1471165 we worked around bindings limitation making the use of optional dictionary with required arguments impossible.

bug 1368949 makes it feasible.

Comment 1

[Jean-Yves Avenard [:jya]]

P1 needs reversing.

Comment 2

[Nils Ohlmeier [:drno]]

(In reply to Jean-Yves Avenard [:jya] from comment #1)
> P1 needs reversing.

Not sure if you are saying this should be P1. If you think so, then feel free to change it to that. But then the bug also needs an owner :-)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1493798. Update the MediaCapabilities dictionaries to follow the spec more closely. r=jya

This partially backs out bug 1471165 now that we don't enforce a default value
for dictionary-typed members of dictionaries.

Comment 4

[Jean-Yves Avenard [:jya]]

(In reply to Nils Ohlmeier [:drno] from comment #2)
> (In reply to Jean-Yves Avenard [:jya] from comment #1)
> > P1 needs reversing.
> 
> Not sure if you are saying this should be P1. If you think so, then feel
> free to change it to that. But then the bug also needs an owner :-)

P1 refers to the changeset as in part 1

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 9012037 [details]
Bug 1493798.  Update the MediaCapabilities dictionaries to follow the spec more closely.  r=jya

Jean-Yves Avenard [:jya] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4c0087797d6
Update the MediaCapabilities dictionaries to follow the spec more closely.  r=jya

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13227 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a4c0087797d6

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13227
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/TDr06MVZQSGVyGHFrx9K2g)