Closed Bug 1493853 Opened 7 years ago Closed 7 years ago

Sharing file links in review is broken

Categories

(Conduit :: Phabricator, defect)

Product:
Conduit
Component:
Phabricator
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: marcosc, Unassigned)

Details

STR: 1. Go to https://phabricator.services.mozilla.com/D637 2. Select file dom/payments/test/BasicCardErrorsChromeScript.js 3. Copy the url from the address bar (with the fragment id) 4. Open a new tab, paste the URL and hit enter. Expected: page should load and jump to "BasicCardErrorsChromeScript.js" Actual: The website loads and ends up somewhere near "dom/payments/BasicCardPayment.cpp" The use case is being able to share links to files for discussion.
I'm about 90% certain that this is a duplicate of Bug 668213, which is related to Bug 1476049 and Bug 60307.
It happens in Safari too, so not sure if it's just Firefox related (unless Safari is also broken :)). But thanks for checking nonetheless.
Hm this seems to work for me; I tried it on a number of files in different revisions. I also don't see the file you mentioned in D637 so I can't verify your specific issue.
Flags: needinfo?(mcaceres)
Odd... do those IDs (e.g., D637) get recycled? Any any case, confirmed it's working now in Firefox.
Flags: needinfo?(mcaceres)
Nope, they should live forever... Okay resolving WORKSFORME; feel free to reopen if it occurs again.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.