Closed
Bug 1493854
Opened 7 years ago
Closed 5 years ago
Feature request: link to line numbers
Categories
(Conduit :: Phabricator, enhancement, P5)
Conduit
Phabricator
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1697944
People
(Reporter: marcosc, Unassigned)
References
Details
(Keywords: conduit-triaged, conduit-upstream)
It would be nice to be able to get links to particular line numbers in files.
For example, in github, I can have a pull request, and link to a line number without making a comment:
https://github.com/w3c/payment-request/pull/749/files#diff-eacf331f0ffc35d4b482f1d15a887d3bR1049
Having the same functionality would be great, as it makes it easier to share/discuss bits of code with people.
Bonus points if it's possible to link to a range of line numbers.
|
||
Updated•7 years ago
|
Keywords: conduit-triaged
Whiteboard: [phabricator-backlog][phabricator-upstream]
Keywords: conduit-backlog,
conduit-upstream
Whiteboard: [phabricator-backlog][phabricator-upstream]
Keywords: conduit-backlog
Priority: -- → P5
|
|
||
Comment 1•6 years ago
|
||
I find this a constant irritation when trying to interactively discuss a patch with a review requester (or reviewer). Any chance this could be given higher priority than P5?
|
|
||
Comment 2•6 years ago
|
||
FWIW there are already "OL" and "NL" (presumably "old line" and "new line") 'id' attributes for each line in the source code.
|
||
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•