Closed
Bug 1493887
Opened 6 years ago
Closed 6 years ago
Text for some items in Main Menu are not horizontally aligned after 1492130
Categories
(Toolkit :: Themes, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox62 | --- | unaffected |
| firefox63 | --- | unaffected |
| firefox64 | --- | fixed |
People
(Reporter: Fanolian+BMO, Assigned: dao)
References
(Regression)
Details
(Keywords: nightly-community, regression, reproducible)
Attachments
(2 files)
|
57.82 KB,
image/png
|
Details | |
|
1.58 KB,
patch
|
Paolo
:
review+
|
Details | Diff | Splinter Review |
Hamburger menu text
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0 Build ID: 20180924220042 Please refer to the screenshot. After bug 1492130, the gap are widened between the icon and the text for most items.
Flags: needinfo?(dao+bmo)
|
Assignee | |
Comment 1•6 years ago
|
||
Do you still see this with bug 1492130 being fixed?
Flags: needinfo?(dao+bmo) → needinfo?(Fanolian+bugzilla)
(In reply to Dão Gottwald [::dao] from comment #1) > Do you still see this with bug 1492130 being fixed? Do you mean any other bugs? This bug is introduced by the patch in bug 1492130, and is still reproducible in current Nightly (20180924220042).
Flags: needinfo?(Fanolian+bugzilla) → needinfo?(dao+bmo)
(In reply to Fanolian from comment #2) > This bug is introduced by the patch in bug 1492130 I got this conclusion by using Mozregression, if you wonder.
|
|
Assignee | |
Comment 4•6 years ago
|
||
(In reply to Fanolian from comment #2) > (In reply to Dão Gottwald [::dao] from comment #1) > > Do you still see this with bug 1492130 being fixed? > > Do you mean any other bugs? Yeah, I meant bug 1493638.
Flags: needinfo?(dao+bmo)
I believe bug 1493638 had been pushed to current Nightly (20180924220042), according to https://hg.mozilla.org/mozilla-central/rev/fcd124fe04e7: >first release with nightly win64 ea12f08bca89 / 64.0a1 / 20180924220042 / files (In reply to Dão Gottwald [::dao] from comment #1) > Do you still see this with bug 1492130 being fixed? So yes, I still see this after bug 1492130.
Flags: needinfo?(dao+bmo)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → dao+bmo
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(dao+bmo)
Priority: -- → P1
|
|
Assignee | |
Comment 6•6 years ago
|
||
https://screenshots.mattn.ca/compare/?oldProject=try&oldRev=c40913e6a524a21cc1aa74e8e360cce268770478&newProject=try&newRev=6f243db3060cb99718c5bb37a9ab5e524ad9a6c2
Attachment #9011893 -
Flags: review?(paolo.mozmail)
|
||
Comment 7•6 years ago
|
||
Comment on attachment 9011893 [details] [diff] [review] patch r+ since it seems this patch is just removing other unneeded base styling, but please check that the new screenshots, for the main menu in particular, match what we had before "toolbarbutton.css" became a document stylesheet.
Attachment #9011893 -
Flags: review?(paolo.mozmail) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/76ad499b825f Remove toolbarbutton-icon default padding. r=paolo
Keywords: checkin-needed
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/76ad499b825f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
|
||
Updated•6 years ago
|
status-firefox-esr60:
--- → unaffected
status-geckoview62:
unaffected → ---
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•