Closed Bug 1493918 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 13191 - Use MoveParagraphWithClones when moving paragraphs to new list items

Categories

(Core :: DOM: Editor, enhancement, P4)

Product:
Core
Component:
DOM: Editor
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 13191 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13191
Details from upstream follow.

Javier Fernandez <jfernandez@igalia.com> wrote:
>  Use MoveParagraphWithClones when moving paragraphs to new list items
>  
>  The MoveParagraph function doesn't guarantee the paragraph style is
>  preserved when the insertOrderedList/insertOnordered list commands
>  are used.
>  
>  Instead, we should use MoveParagraphWithClones. This change implies
>  rebaseline a few tests, since the result tree is different than the
>  one created with MoveParagraph.
>  
>  Bug: 149901
>  Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
>  Change-Id: I01e5a9ade28d3c16e8dc5423bf16dcf0d7e60976
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1216282
>  WPT-Export-Revision: 08584cc02bf4be4beeb904ecb43d18bf5385ffb9
Component: web-platform-tests → Editor
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 3 tests and 1767 subtests
OK     : 3
PASS   : 1595
FAIL   : 172

New tests that have failures or other problems:
/editing/run/insertorderedlist.html
    [["insertorderedlist",""]] "<div><ol style='font-family: times; color: blue'><li>bar</li></ol><span style='font-family: italic; color: green'>[baz]</span></div>" compare innerHTML: FAIL
    [["insertorderedlist",""]] "<div><ol style='font-family: times; color: blue'><li>bar</li></ol><span style='font-family: italic; color: green'>[baz]</span></div>" queryCommandValue("insertorderedlist") after: FAIL
    [["insertorderedlist",""]] "<div><ol style='font-family: times; color: blue'><li>bar</li></ol><span style='font-family: italic; color: green'>[baz]</span></div>" queryCommandValue("insertorderedlist") before: FAIL
    [["insertorderedlist",""]] "<div><span style='font-family: times; color: blue'>[bar]</span></div>" compare innerHTML: FAIL
    [["insertorderedlist",""]] "<div><span style='font-family: times; color: blue'>[bar]</span></div>" queryCommandValue("insertorderedlist") after: FAIL
    [["insertorderedlist",""]] "<div><span style='font-family: times; color: blue'>[bar]</span></div>" queryCommandValue("insertorderedlist") before: FAIL
    [["insertorderedlist",""]] "<div><span style='font-family: times; color: blue'>bar</span></div><span style='font-family: italic; color: green'>[baz]</span>" queryCommandValue("insertorderedlist") after: FAIL
    [["insertorderedlist",""]] "<div><span style='font-family: times; color: blue'>bar</span></div><span style='font-family: italic; color: green'>[baz]</span>" queryCommandValue("insertorderedlist") before: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae9cfc868acf
[wpt PR 13191] - Use MoveParagraphWithClones when moving paragraphs to new list items, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b69baa83929
[wpt PR 13191] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/ae9cfc868acf
https://hg.mozilla.org/mozilla-central/rev/5b69baa83929
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.