Closed Bug 1493932 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 13198 - [css-contain] Fix size containment on fieldsets

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 13198 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13198
Details from upstream follow.

Manuel Rego Casasnovas <rego@igalia.com> wrote:
>  [css-contain] Fix size containment on fieldsets
>  
>  Fieldsets with "contain: size" were not ignoring the legend
>  when determining their size.
>  
>  Spec (https://drafts.csswg.org/css-contain/#containment-size):
>    "When calculating the size of the containing element,
>     it must be treated as having no contents."
>  
>  The patch is just an early return in
>  LayoutFieldset::ComputePreferredLogicalWidths()
>  like we have in other parts of the code.
>  
>  BUG=882388
>  TEST=external/wpt/css/css-contain/contain-size-fieldset-001.html
>  
>  Change-Id: I79425cf9c10ecf794f52cb4f635b95e1be059d81
>  Reviewed-on: https://chromium-review.googlesource.com/1242357
>  WPT-Export-Revision: fc185a605f7c3febe88ec8a220e9ac201b16a85c
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 1 tests
PASS   : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fc7a610766c
[wpt PR 13198] - [css-contain] Fix size containment on fieldsets, a=testonly
https://hg.mozilla.org/mozilla-central/rev/6fc7a610766c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.