Closed Bug 1493956 Opened Last year Closed Last year

Explicitly pass in a principal into nsFrameLoader loadURI calls

Categories

(Core :: DOM: Security, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: jkt, Assigned: jkt)

References

(Blocks 1 open bug)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file)

dom/base/nsFrameLoader.cpp doesn't always pass an explicit triggering principal and I think we can just add this in without any issues.
Whiteboard: [domsecurity-active]
Comment on attachment 9011777 [details]
Bug 1493956 - Pass an explicit triggeringPrincipal in nsFrameLoader. r?ckerschb r?nika

Christoph Kerschbaumer [:ckerschb] has approved the revision.
Attachment #9011777 - Flags: review+
Comment on attachment 9011777 [details]
Bug 1493956 - Pass an explicit triggeringPrincipal in nsFrameLoader. r?ckerschb r?nika

Hey Nika,
I'm not sure if you get phab updates here. I think I addressed your feedback.
Thank you.
Attachment #9011777 - Flags: review?(nika)
Comment on attachment 9011777 [details]
Bug 1493956 - Pass an explicit triggeringPrincipal in nsFrameLoader. r?ckerschb r?nika

:Nika Layzell has approved the revision.
Attachment #9011777 - Flags: review+
Pushed by jkingston@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2cdac78b6bcd
Pass an explicit triggeringPrincipal in nsFrameLoader. r=ckerschb,nika
Attachment #9011777 - Flags: review?(nika)
https://hg.mozilla.org/mozilla-central/rev/2cdac78b6bcd
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.