1494007 - [RTL] Mirror the wrench icon and fix its padding

Status: RESOLVED WONTFIX

(Firefox :: Enterprise Policies, defect, P3)

Description

[Itiel]

Attachment: about:policies wrench in RTL

See attached screenshot.

Comment 1

[u626306]

Is this bug still open?
I am a new contributor looking for somewhere to start.

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Hello, thanks for volunteering!

Do you have experience with CSS? This is what this bug will need.

First, to get started, you'll need to check out a copy of the Firefox source
code from Mercurial:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Source_Code/Mercurial)

Then you need to be set up the build environment to compile/build it. Since to fix this bug it won't be necessary to recompile any binary components for Firefox, I recommend setting up an artifact build which is much faster and easier to use:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Artifact_builds


Once you have that working let me know and I can guide you on how to work on this bug

Comment 3

[u626306]

Hi,

I do have experience with CSS.
I have a copy of the Firefox source (the git mirror) that I built on Saturday (following this guide: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build/Linux_and_MacOS_build_preparation)
However it's the full version.

Thanks.

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Ok, no problem about it being the full version. When you make changes, I suggest you run `mach build faster` instead of just `mach build`, which will be slightly faster.

To test the browser in the RTL direction, you can go to about:config and change the pref "intl.uidirection" to 1.

The files related to this about:policies page can be found in the browser/components/enterprisepolicies/content folder [1]. Specifically, look for the CSS file there.

You can use the Inspector to inspect the page, and the :dir(rtl) CSS selector to write a selector that will only apply in the RTL condition.



[1] https://searchfox.org/mozilla-central/source/browser/components/enterprisepolicies/content

Comment 5

[u626306]

Thank you for the info, can't wait to get started!

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Hello adnan,

Recently we discovered that the machine_only concept (which this icon represents) is not really useful (see bug 1507291 for more details), and we're planning on removing it. So I don't want you to spend time on this bug for nothing. As a suggestion for another bug, would you like to work on bug 1497928? I'll be mentoring that bug too

Comment 7

[u626306]

Hi Felipe,

Thanks for the heads up.
For 1497928, it seems 2 people (Pablo Lluch and JZ) are attempting to do it, so I'll skip that one.
I was considering Bug 1485636 or Bug 1485193, I've added a comment in the latter bug to know if it's available. If it is, I'll ask to be assigned there, otherwise I'll ask to be assigned to 1485636.