1494033 - onBeforeSendHeaders/onSendHeaders not called after onAuthRequired

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[Shane Caraveo (:mixedpuppy)]

Both onBeforeSendHeaders/onBeforeSend and called via the http-on-before-connect notification, which ONLY happens just prior to an actual connection.  This was added in bug 1368527.

http-on-before-connect should also be called from nsHttpChannel::DoAuthRetry where a new transaction is initiated.  DoAuthRetry will need some heavy work, buth on-modify and on-before-connect should be handled async here.  Currently on-modified is called, but the async result is not handled.

Comment 1

[Honza Bambas (:mayhemer)]

I think this is a necko bug.  Something I can either work on or mentor/review.

Comment 2

[Shane Caraveo (:mixedpuppy)]

It's certainly a bug in nsHttpChannel.  I added the http-on-before-connect notification because the hacky way we handled webRequest.onBeforeSendHeaders/onBeforeSend didn't work right.  Unfortunately it doesn't cover this situation.

Comment 3

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1494033 test event order with onAuthRequired

Adds testing webrequest events related to async handling in httpChannel
that was added in bug 1407384.

Comment 4

[Shane Caraveo (:mixedpuppy)]

This bug was fixed by bug 1407384, just adding a test.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd9b6ab6d564
test event order with onAuthRequired r=zombie

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/fd9b6ab6d564

Comment 7

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/projects/ash/rev/fd9b6ab6d5647258849e9f09949ac3399585f87e
Bug 1494033 test event order with onAuthRequired r=zombie