Remove mURIFixup and use Services.uriFixup instead

RESOLVED FIXED in Firefox 65

Status

()

P3
normal
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: dao, Assigned: rishabhjairath, Mentored)

Tracking

({good-first-bug})

Trunk
Firefox 65
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox65 fixed)

Details

(Whiteboard: [lang=js])

Attachments

(1 attachment)

(Reporter)

Description

6 months ago
We should remove the mURIFixup line here:

https://searchfox.org/mozilla-central/rev/881a3c5664ede5e08ee986d76433bc5c4b5680e6/browser/base/content/tabbrowser.js#27

And use Services.uriFixup instead of this.mURIFixup throughout tabbrowser.js.
Comment hidden (obsolete)
Comment hidden (obsolete)
Comment hidden (obsolete)
Comment hidden (obsolete)
(Reporter)

Updated

5 months ago
Assignee: kajalksah07 → nobody
Status: ASSIGNED → NEW
(Assignee)

Comment 5

5 months ago
Hi Dao,
I would like to resolve this bug as my first contribution.
Thanks

Comment 6

5 months ago
Hi Dao,
I am interested in this bug. Have my setup done on my local machine.
Thanks.
(Reporter)

Comment 7

5 months ago
(In reply to rishabhjairath from comment #5)
> Hi Dao,
> I would like to resolve this bug as my first contribution.
> Thanks

How far along are you towards creating a patch?
(Assignee)

Comment 8

5 months ago
https://phabricator.services.mozilla.com/D10015

Hi Dao,
Can you review my changes.
(Reporter)

Comment 10

5 months ago
Added review comments in phabricator.
Assignee: nobody → rishabhjairath
(Reporter)

Comment 11

5 months ago
Are you able to address the review comments in phabricator?
Flags: needinfo?(rishabhjairath)
(Assignee)

Comment 12

5 months ago
I have made the changes as mentioned in the review comments.
Flags: needinfo?(rishabhjairath)
Attachment #9020872 - Attachment description: Bug 1494045 - used Services.uriFixup instead of this.mURIFixup in tabbrowser.js → Bug 1494045 - Remove mURIFixup and use Services.uriFixup

Comment 13

5 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad7b9c6e1947
Remove mURIFixup and use Services.uriFixup r=dao

Comment 14

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ad7b9c6e1947
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.