Closed Bug 1494045 Opened 3 years ago Closed 3 years ago

Remove mURIFixup and use Services.uriFixup instead

Categories

(Firefox :: Tabbed Browser, enhancement, P3)

Product:
Firefox
Component:
Tabbed Browser
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: dao, Assigned: rishabhjairath, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file)

Bug 1494045 - Remove mURIFixup and use Services.uriFixup
47 bytes, text/x-phabricator-request
Details | Review 
We should remove the mURIFixup line here:

https://searchfox.org/mozilla-central/rev/881a3c5664ede5e08ee986d76433bc5c4b5680e6/browser/base/content/tabbrowser.js#27

And use Services.uriFixup instead of this.mURIFixup throughout tabbrowser.js.
Assignee: kajalksah07 → nobody
Status: ASSIGNED → NEW
Hi Dao,
I would like to resolve this bug as my first contribution.
Thanks
Hi Dao,
I am interested in this bug. Have my setup done on my local machine.
Thanks.
(In reply to rishabhjairath from comment #5)
> Hi Dao,
> I would like to resolve this bug as my first contribution.
> Thanks

How far along are you towards creating a patch?
https://phabricator.services.mozilla.com/D10015

Hi Dao,
Can you review my changes.
Added review comments in phabricator.
Assignee: nobody → rishabhjairath
Are you able to address the review comments in phabricator?
Flags: needinfo?(rishabhjairath)
I have made the changes as mentioned in the review comments.
Flags: needinfo?(rishabhjairath)
Attachment #9020872 - Attachment description: Bug 1494045 - used Services.uriFixup instead of this.mURIFixup in tabbrowser.js → Bug 1494045 - Remove mURIFixup and use Services.uriFixup
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad7b9c6e1947
Remove mURIFixup and use Services.uriFixup r=dao
https://hg.mozilla.org/mozilla-central/rev/ad7b9c6e1947
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.