Closed Bug 1494046 Opened 1 year ago Closed 1 year ago

Wrong bookmark folder icon showing for the "Other Bookmarks" folder in Bookmark Edit window


(Firefox :: Bookmarks & History, defect, P3)

62 Branch



Firefox 65
Tracking Status
firefox65 --- fixed


(Reporter: loxia_01, Assigned: standard8)




(2 files)

Attached image bug_other bookmarks.png
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180920131237

Steps to reproduce:

Opened the Edit Bookmark window AND then in the Drop-Down menu clicked "Choose...", which direct you to the Other Bookmarks folder (even if you were there before you clicked).

Actual results:

The icon for the Other Bookmarks folder now showed the generic bookmark folder icon instead of the special Other Bookmarks folder icon.

Expected results:

The bookmark icon shown, should have been the special Other Bookmarks folder icon, not the generic one.

A very minor bug, but indeed a bug.
More technical info on the bug in this forum answer:
Component: Untriaged → Bookmarks & History
I can confirm this (ignore most of the sumo thread - that's about userChrome.css which this isn't related to).
Ever confirmed: true
Priority: -- → P3
In addition, a similar bug is present when using the Add-on "Default Bookmark Folder" and setting a custom bookmarks default folder. After bookmarking a new page, this default folder always shows the icon for the "Other Bookmarks" in the Add/Edit Bookmark dialog, instead of the correct folder icon.

(Perhaps this should be a new bug thread?)
It is close enough to this bug it can be included in the same one.
Assignee: nobody → standard8
Change to using an event listener to follow when the selection changes more accurately. Also switch to using GUIDs as they are better defined than indexes.
Pushed by
Improve how the folder icon is selected on the folder list in the bookmark popup window. r=mak
That's strange, just OS X only on debug and looking unrelated. I think there is something going on here, but I haven't quite put my finger on what's wrong. Will investigate more tomorrow.
I'm still looking at this, but dropping the NI for now.
Flags: needinfo?(standard8)
Depends on: 1501337
Pushed by
Improve how the folder icon is selected on the folder list in the bookmark popup window. r=mak
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
I have reproduced this bug with Nightly 64.0a1 (2018-09-21) on Windows 7, 64 Bit!
This bug's fix is verified with latest Nightly!

Build ID 	20181126100057
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0
QA Whiteboard: [bugday-20181128]
You need to log in before you can comment on or make changes to this bug.